Squiz/FunctionDeclarationArgumentSpacing: handle asym modifiers for constructor property promotion #1121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
php-8.4/feature/file-methods-support-asym-visibility
to
master
June 9, 2025 01:45
…onstructor property promotion This commit adds handling of the spacing after asymmetric visibility modifiers used for constructor property promotion to this sniff. The spacing requirements are aligned with the spacing expectations of the `Squiz.WhiteSpace.ScopeKeywordSpacing` sniff, so the sniffs should not conflict with each other. Additionally, the new check has a dedicated error code, which means that - if there would be a conflict anywhere - the asym visibility spacing check within this sniff can easily be turned off. Includes tests.
jrfnl
force-pushed
the
php-8.4/feature/squiz-functiondeclarationargspacing-support-asym-visibility
branch
from
9fa77a2 to
af2465a
Compare
|
Rebased without changes to get a proper build. |
jrfnl
deleted the
php-8.4/feature/squiz-functiondeclarationargspacing-support-asym-visibility
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit adds handling of the spacing after asymmetric visibility modifiers used for constructor property promotion to this sniff.
The spacing requirements are aligned with the spacing expectations of the
Squiz.WhiteSpace.ScopeKeywordSpacingsniff, so the sniffs should not conflict with each other.Additionally, the new check has a dedicated error code, which means that - if there would be a conflict anywhere - the asym visibility spacing check within this sniff can easily be turned off.
Includes tests.
Suggested changelog entry
Related issues/external references
Follow up on #851
Follow up on #1116
Related to #734