Squiz/FunctionDeclarationArgumentSpacing: fix typo in SpacingAfterSetVis[i]bility error code
#1135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
changed the title
SpacingAfterSetVis[i]bility error code
…tVis[i]bility` error code The `SpacingAfterVis[i]bility` error code was introduced in v 3.12.0 (March this year) for constructor property promotion. The `SpacingAfterSetVis[i]bility` error code was introduced in v 3.13.1 (few days ago) for constructor property promotion with asym visibility. Both contained the same typo. Now, changing an error code is a breaking change. However, with 3.13.1 only having been released a few days ago, it is my opinion that if released soon as 3.13.2, this is an acceptable bug fix. But then, it would be really weird to not fix the other error code in the same version. Then again, as PHPCS 4.0.0 is around the corner and does allow for breaking changes, let's leave the older typo for 4.0.0, just to be on the safe side.
jrfnl
force-pushed
the
feature/squiz-functiondeclarationargumentspacing-fix-errorcode
branch
from
7d07cf5 to
a1c2aaa
Compare
jrfnl
added a commit
that referenced
this pull request
Jun 17, 2025
…s[i]bility` error code Follow up on #792, related to #1135 The `SpacingAfterVis[i]bility` error code was introduced in v 3.12.0 (March this year) for constructor property promotion. The `SpacingAfterSetVis[i]bility` error code was introduced in v 3.13.1 (this month) for constructor property promotion with asym visibility. Both contained the same typo. PR 1135 fixes the asym error code and will be included in PHPCS 3.13.2. This commit now fixes the non-asym error code and will be included in PHPCS 4.0.0.
Merged
5 tasks
jrfnl
deleted the
feature/squiz-functiondeclarationargumentspacing-fix-errorcode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up on #1121
The
SpacingAfterVis[i]bilityerror code was introduced in v 3.12.0 (March this year) for constructor property promotion.The
SpacingAfterSetVis[i]bilityerror code was introduced in v 3.13.1 (few days ago) for constructor property promotion with asym visibility.Both contained the same typo.
Now, changing an error code is a breaking change. However, with 3.13.1 only having been released a few days ago, it is my opinion that if released soon as 3.13.2, this is an acceptable bug fix.
But then, it would be really weird to not fix the other error code in the same version. Then again, as PHPCS 4.0.0 is around the corner and does allow for breaking changes, let's leave the older typo for 4.0.0, just to be on the safe side.
Suggested changelog entry
Fixed: Squiz.Functions.FunctionDeclarationArgumentSpacing: fixed typo in new error code
SpacingAfterSetVis[i]bility