Allows linking nodes in the message flow view as a fallback when no link could be established on OriginatingEndpoint / ProcessingEndpoint mismatch #1171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamBZA
reviewed
Feb 11, 2022
@WilliamBZA No tests exist at all against this view model. Potentially the |
|
I'm not sure that I'm the right person to review this PR. I can review the code but am not really sure I'm able to follow the implication of the change. |
|
@danielmarbach to answer your question: logs are displayed within SI in the Logs window. The reason to mark them as Warn/Error was to make them stand out as we log other things there as well. If you want to argue "what's the action" you can argue why we log anything at all. The error logs in the diagram code are not 'expected'. Maybe those can be replaced by exceptions. Those conditions are not expected to happen. When customers do report those, we'll need to check their (SC) data to see why that happens. |
ramonsmits
force-pushed
the
relatedto-endpoint-mismatch-fallback
branch
from
9147a3c to
8e77754
Compare
ramonsmits
changed the title
ramonsmits
changed the title
WilliamBZA
approved these changes
Nov 25, 2022
…here is no match on child.RelatedTo = parent.Id && child.OriginatingEndpoint = parent.ProcessingEndpoint
Co-authored-by: Daniel Marbach <[email protected]>
ramonsmits
force-pushed
the
relatedto-endpoint-mismatch-fallback
branch
from
c0d5e85 to
c0dc8fa
Compare
|
Is rebased on top of dev-exp-upgrade-buid-fix, needs #1288 to be merged first. |
HEskandari
reviewed
Nov 29, 2022
HEskandari
reviewed
Nov 29, 2022
ramonsmits
commented
Nov 29, 2022
HEskandari
approved these changes
Nov 29, 2022
cquirosj
added a commit
that referenced
this pull request
Dec 6, 2022
…ink could be established on OriginatingEndpoint / ProcessingEndpoint mismatch (#1171) * Allows linking nodes if originating message is not an event in case there is no match on child.RelatedTo = parent.Id && child.OriginatingEndpoint = parent.ProcessingEndpoint * Implemented logging TODO's * Removed unneeded TODO * Resolved ESSENTIAL formatting fix IDE0055...... * Apply suggestions from code review Co-authored-by: Daniel Marbach <[email protected]> * Update src/ServiceInsight/MessageFlow/MessageFlowViewModel.cs * Using names instead of numbers for Serilog messages * Fix missing ToArray * Converted to switch for reabability of intent Co-authored-by: Daniel Marbach <[email protected]> # Conflicts: # src/ServiceInsight/MessageFlow/MessageFlowViewModel.cs
cquirosj
added a commit
that referenced
this pull request
Dec 6, 2022
…ink could be established on OriginatingEndpoint / ProcessingEndpoint mismatch (#1171) * Allows linking nodes if originating message is not an event in case there is no match on child.RelatedTo = parent.Id && child.OriginatingEndpoint = parent.ProcessingEndpoint * Implemented logging TODO's * Removed unneeded TODO * Resolved ESSENTIAL formatting fix IDE0055...... * Apply suggestions from code review Co-authored-by: Daniel Marbach <[email protected]> * Update src/ServiceInsight/MessageFlow/MessageFlowViewModel.cs * Using names instead of numbers for Serilog messages * Fix missing ToArray * Converted to switch for reabability of intent Co-authored-by: Daniel Marbach <[email protected]> # Conflicts: # src/ServiceInsight/MessageFlow/MessageFlowViewModel.cs
soujay
pushed a commit
that referenced
this pull request
Dec 6, 2022
…ink could be established on OriginatingEndpoint / ProcessingEndpoint mismatch (#1171) (#1294) * Allows linking nodes if originating message is not an event in case there is no match on child.RelatedTo = parent.Id && child.OriginatingEndpoint = parent.ProcessingEndpoint * Implemented logging TODO's * Removed unneeded TODO * Resolved ESSENTIAL formatting fix IDE0055...... * Apply suggestions from code review Co-authored-by: Daniel Marbach <[email protected]> * Update src/ServiceInsight/MessageFlow/MessageFlowViewModel.cs * Using names instead of numbers for Serilog messages * Fix missing ToArray * Converted to switch for reabability of intent Co-authored-by: Daniel Marbach <[email protected]> # Conflicts: # src/ServiceInsight/MessageFlow/MessageFlowViewModel.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to link nodes the following must be true:
However, in situaties where only processed messages can be linked based on RelatedTo these messages remain unlinked in the message flow view.
Before:
After:
Logic is written in such a way that the fallback only happens if intent not equal to publish. Meaning, only messages and commands as these SHOULD only have one processing endpoint
Implications
This is a fallback, the default linking behavior remains the same is the message flow is purely passing only NServiceBus endpoints but adds linking when that is not always the case (i.e. native integration).