Allows linking nodes in the message flow view as a fallback when no link could be established on OriginatingEndpoint / ProcessingEndpoint mismatch #1294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ink could be established on OriginatingEndpoint / ProcessingEndpoint mismatch (#1171) * Allows linking nodes if originating message is not an event in case there is no match on child.RelatedTo = parent.Id && child.OriginatingEndpoint = parent.ProcessingEndpoint * Implemented logging TODO's * Removed unneeded TODO * Resolved ESSENTIAL formatting fix IDE0055...... * Apply suggestions from code review Co-authored-by: Daniel Marbach <[email protected]> * Update src/ServiceInsight/MessageFlow/MessageFlowViewModel.cs * Using names instead of numbers for Serilog messages * Fix missing ToArray * Converted to switch for reabability of intent Co-authored-by: Daniel Marbach <[email protected]> # Conflicts: # src/ServiceInsight/MessageFlow/MessageFlowViewModel.cs
HEskandari
approved these changes
Dec 6, 2022
soujay
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-doing the changes from pull request #1171 into master