remove flake8-mypy tests #550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nic-Ma
approved these changes
Jun 12, 2020
There was a problem hiding this comment.
It looks good to me.
@hjmjohnson could you please help also review this PR as you guys are working on this topic?
Thanks.
hjmjohnson
approved these changes
Jun 12, 2020
ghost
pushed a commit
to BRAINSia/MONAI
that referenced
this pull request
Jul 7, 2020
ghost
pushed a commit
to BRAINSia/MONAI
that referenced
this pull request
Jul 7, 2020
ghost
pushed a commit
to BRAINSia/MONAI
that referenced
this pull request
Jul 8, 2020
ghost
pushed a commit
to BRAINSia/MONAI
that referenced
this pull request
Jul 9, 2020
wyli
pushed a commit
that referenced
this pull request
Jul 9, 2020
* Set set_type_checking_flag for autodoc-typehints
Fixes 11 out of the 17 warnings when running 'make html'
WARNING: Cannot resolve forward reference in type annotations of "{}":
name 'ignite' is not defined
* Reenable and fix flake8-bugbear errors
B007
Loop control variable '{}' not used within the loop body. If this is
intended, start the name with an underscore.
B008
See #727
* Reenable and fix flake8-comprehensions errors
C402
Unnecessary generator - rewrite as a dict comprehension.
C407
Unnecessary list comprehension - '{}' can take a generator.
C416
Unnecessary list comprehension - rewrite using list().
* Reenable and fix flake8 unused import errors
F401
'{}' imported but unused
* Remove flake8-mypy configurations
See #550
* Reenable and fix mypy-torch errors
- Argument "{}" to "{}" has incompatible type "{}"; expected "{}"
- Incompatible types in assignment (expression has type "{}", variable has type "{}")
- Module "{}" is not valid as a type
- Module has no attribute "{}"
- Name '{}' is not defined
- No overload variant of "{}" of "{}" matches argument types
* Update the issue number of signature incompatible
See #729
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #476.
currently we have both flake8-mypy (as a plugin of flake8) and mypy package doing similar type checking. flake8-mypy has some issues and the error messages are not very straightforward.
this PR proposes to remove flake8-mypy tests.
Status
Ready
Types of changes