Reenable checks and fix errors #717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
ghost
commented
Jul 8, 2020
ghost
commented
Jul 8, 2020
ghost
changed the title
added 5 commits
July 9, 2020 10:29
Fixes 11 out of the 17 warnings when running 'make html'
WARNING: Cannot resolve forward reference in type annotations of "{}":
name 'ignite' is not defined
B007
Loop control variable '{}' not used within the loop body. If this is
intended, start the name with an underscore.
B008
See Project-MONAI#727
C402
Unnecessary generator - rewrite as a dict comprehension.
C407
Unnecessary list comprehension - '{}' can take a generator.
C416
Unnecessary list comprehension - rewrite using list().
F401
'{}' imported but unused
4 tasks
wyli
reviewed
Jul 9, 2020
added 2 commits
July 9, 2020 11:46
- Argument "{}" to "{}" has incompatible type "{}"; expected "{}"
- Incompatible types in assignment (expression has type "{}", variable has type "{}")
- Module "{}" is not valid as a type
- Module has no attribute "{}"
- Name '{}' is not defined
- No overload variant of "{}" of "{}" matches argument types
There are still various missing type hints; I think we will need to resolve them first. Since the larger commits are taken care of I think it would be beneficial to have all checks running for the rest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix currently ignored errors and reenable corresponding checks
autodoc-typehints: enable flag (TYPE_CHECKING imports)flake8-bugbear: reenable checks and fix errorsflake8-comprehensions: reenable checks and fix errorsflake8 unused imports: reenable checks and fix errorsflake8-mypy: remove checks (no longer using)mypy-torch: reenable checks and fix errorsStatus
Ready
Types of changes