rsx: Avoid data loss in blit engine when WCB/WDB + RCB/RDB is active #14907
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a data loss path if WCB is enabled when CELL writes to RSX mem, or RSX commands do a write that causes a flush from GPU to CPU then is overwritten. If we don't detect it in the surface "test" method (very likely due to low sample count) we just lock the memory again and the writes are lost forever. This is extremely bad in some cases because we can lose shaders and other important RSX data causing all kinds of problems and crashes.
Closes #14901
Relates to #9133