Skip to content

ENH: adding name as a karg in Flight class #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 14, 2022
Merged

ENH: adding name as a karg in Flight class #293

merged 3 commits into from
Nov 14, 2022

Conversation

Gui-FernandesBR
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Code base additions (bugfix, features)
  • Code maintenance (refactoring, formatting, renaming, tests)
  • ReadMe, Docs and GitHub maintenance
  • Other (please describe):

Pull request checklist

Please check if your PR fulfills the following requirements, depending on the type of PR:

  • Code base additions (for bug fixes / features):

    • Tests for the changes have been added
    • Docs have been reviewed and added / updated if needed
    • Lint (black rocketpy) has passed locally and any fixes were made
    • All tests (pytest --runslow) have passed locally

What is the current behavior?

I cannot easily differentiate one flight object from other.

What is the new behavior?

New argument and attribute "name" added to Flight class, allowing if to easily label/name your object. It was inspired in the recent AeroSurfaces implementation. This will help a lot on compare plots functions.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Could apply to other classes as well, if evrybody thinks

@github-actions github-actions bot requested a review from MateusStano November 13, 2022 19:54
@Gui-FernandesBR
Copy link
Member Author

Flight class now receives 'name' as argument, so you can give a name for your flight and I can do TestFlight.name without problem.

  1. Does it make sense?
  2. Is that good approach?
  3. Do you know any better approach?

MateusStano
MateusStano reviewed Nov 14, 2022
View reviewed changes
rocketpy/Flight.py Outdated
@@ -527,6 +529,7 @@ def __init__(
atol=6 * [1e-3] + 4 * [1e-6] + 3 * [1e-3],
timeOvershoot=True,
verbose=False,
name="",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make it more standardized with what is in AeroSurfaces I think the default for the name parameter should be name = "Flight"

@MateusStano
Copy link
Member

Flight class now receives 'name' as argument, so you can give a name for your flight and I can do TestFlight.name without problem.

  1. Does it make sense?
  2. Is that good approach?
  3. Do you know any better approach?
  1. yes
  2. i think so
  3. no

I just don't like how many things we are adding to develop branch when all additions that aren't bug fixes should be going to beta/v1.0. Every addition to develop is another merge/rebase we have to do in beta/v1.0

@Gui-FernandesBR Gui-FernandesBR changed the base branch from develop to enh/new_plots November 14, 2022 04:19
Gui-FernandesBR
Gui-FernandesBR commented Nov 14, 2022
View reviewed changes
Gui-FernandesBR
Gui-FernandesBR commented Nov 14, 2022
View reviewed changes
@Gui-FernandesBR
Copy link
Member Author

Flight class now receives 'name' as argument, so you can give a name for your flight and I can do TestFlight.name without problem.

  1. Does it make sense?
  2. Is that good approach?
  3. Do you know any better approach?
  1. yes
  2. i think so
  3. no

I just don't like how many things we are adding to develop branch when all additions that aren't bug fixes should be going to beta/v1.0. Every addition to develop is another merge/rebase we have to do in beta/v1.0

I've updated the PR then, thank you for reviewing

@Gui-FernandesBR Gui-FernandesBR added the Flight Flight Class related features label Nov 14, 2022
@Gui-FernandesBR Gui-FernandesBR added this to the Release v1.0.0 milestone Nov 14, 2022
@Gui-FernandesBR Gui-FernandesBR mentioned this pull request Nov 14, 2022
Merged
6 tasks
@MateusStano
Copy link
Member

Seems good to me then. Feel free to merge

@Gui-FernandesBR Gui-FernandesBR merged commit 6faef4c into enh/new_plots Nov 14, 2022
Gui-FernandesBR added a commit that referenced this pull request Nov 16, 2022
@Gui-FernandesBR
Squashed commit of the following:
4eef4fc 
commit 540be8c
Merge: 6faef4c 14ee975
Author: MateusStano <[email protected]>
Date:   Mon Nov 14 14:50:33 2022 -0300

    Merge pull request #296 from RocketPy-Team/enh/environment_plots

    ENH: Moved Environment plots to environment_plots.py

commit 6faef4c
Merge: 78a0bd8 ca68cd8
Author: Guilherme Fernandes Alves <[email protected]>
Date:   Mon Nov 14 17:02:40 2022 +0100

    Merge pull request #293 from RocketPy-Team/enh/add_name_arguments

    ENH: adding name as a karg in Flight class

commit 14ee975
Merge: fa3faa9 78a0bd8
Author: MateusStano <[email protected]>
Date:   Mon Nov 14 12:39:22 2022 -0300

    Merge branch 'enh/new_plots' into enh/environment_plots

commit 78a0bd8
Merge: 553df48 4ebab9a
Author: MateusStano <[email protected]>
Date:   Mon Nov 14 12:11:54 2022 -0300

    Merge pull request #294 from RocketPy-Team/enh/environment_prints

    ENH: Moved Environment prints to environment_prints.py

commit ca68cd8
Author: Guilherme Fernandes Alves <[email protected]>
Date:   Mon Nov 14 05:20:21 2022 +0100

    MAINT: Update flight docs

commit c37d95f
Author: Guilherme Fernandes Alves <[email protected]>
Date:   Mon Nov 14 05:19:46 2022 +0100

    MAINT: modifying default name value

commit fa3faa9
Author: MateusStano <[email protected]>
Date:   Sun Nov 13 22:25:39 2022 -0300

    maint: docs

commit 64eb8a1
Author: MateusStano <[email protected]>
Date:   Sun Nov 13 22:24:52 2022 -0300

    enh: moved plots from Environment.py to environment_plots.py

commit 4ebab9a
Author: MateusStano <[email protected]>
Date:   Sun Nov 13 21:41:09 2022 -0300

    added author

commit 80776fc
Author: Lint Action <[email protected]>
Date:   Mon Nov 14 00:36:13 2022 +0000

    Fix code style issues with Black

commit c5b4857
Author: Gui-FernandesBR <[email protected]>
Date:   Sun Nov 13 20:50:16 2022 +0100

    ENH: adding name as a karg in Flight class

commit 553df48
Merge: 7925d60 d0da62b
Author: MateusStano <[email protected]>
Date:   Sun Nov 13 16:09:44 2022 -0300

    Merge pull request #289 from RocketPy-Team/enh/flight_prints

    ENH: Moved Flight prints to flight_prints.py

commit d0da62b
Author: MateusStano <[email protected]>
Date:   Sun Nov 13 16:03:18 2022 -0300

    maint: deleted repeated lines of code

commit 67e3711
Author: MateusStano <[email protected]>
Date:   Sun Nov 13 16:02:00 2022 -0300

    enh: changed Environment infos into environment_prints.py

commit 8bbe42f
Merge: 5577ec2 fd8eb41
Author: MateusStano <[email protected]>
Date:   Sun Nov 13 14:35:00 2022 -0300

    Merge branch 'enh/flight_prints' of https://github.com/RocketPy-Team/RocketPy into enh/flight_prints

commit 5577ec2
Author: MateusStano <[email protected]>
Date:   Sun Nov 13 14:34:47 2022 -0300

    maint: removed '\n' from prints

commit d118c0e
Author: MateusStano <[email protected]>
Date:   Sun Nov 13 14:25:05 2022 -0300

    maint: removed 'print' from methods names

commit fd8eb41
Merge: 41f55ca 418ddfd
Author: Gui-FernandesBR <[email protected]>
Date:   Sun Nov 13 17:52:02 2022 +0100

    Merge branch 'enh/flight_prints' of https://github.com/rocketpy-team/rocketpy into enh/flight_prints

commit 41f55ca
Author: Gui-FernandesBR <[email protected]>
Date:   Sun Nov 13 17:51:16 2022 +0100

    Squashed commit of the following:

    commit 7925d60
    Merge: bb5d7c5 3b09de6
    Author: Gui-FernandesBR <[email protected]>
    Date:   Sun Nov 13 17:45:01 2022 +0100

        Merge branch 'beta/v1.0.0' into enh/new_plots

    commit 3b09de6
    Merge: ce5a730 a46aa2e
    Author: Giovani Hidalgo Ceotto <[email protected]>
    Date:   Sat Nov 12 23:34:53 2022 -0300

        Merge pull request #283 from RocketPy-Team/fix/cached_property_py37

        Fix: Cached Property support for Python 3.6 and 3.7

    commit a46aa2e
    Author: Lint Action <[email protected]>
    Date:   Sun Nov 13 02:09:36 2022 +0000

        Fix code style issues with Black

    commit b81e30f
    Author: Giovani Hidalgo Ceotto <[email protected]>
    Date:   Sat Nov 12 23:09:03 2022 -0300

        ENH: Prevents cached_property decorator from being used before `__set_name__`

    commit d7a8e60
    Author: Giovani Hidalgo Ceotto <[email protected]>
    Date:   Sat Nov 12 00:43:48 2022 -0300

        FIX: import local cached_property if standard does not exist

    commit d24fce7
    Author: Giovani Hidalgo Ceotto <[email protected]>
    Date:   Sat Nov 12 00:43:09 2022 -0300

        ENH: created a cached_property decorator

    commit ce5a730
    Merge: d3a9c63 a9f9fab
    Author: Gui-FernandesBR <[email protected]>
    Date:   Thu Nov 3 13:39:13 2022 +0100

        Merge remote-tracking branch 'origin/master' into develop

    commit d3a9c63
    Merge: ba8c7bd f7c7a19
    Author: Guilherme Fernandes Alves <[email protected]>
    Date:   Thu Nov 3 12:31:08 2022 +0100

        Merge pull request #263 from RocketPy-Team/enh/aero_surfaces_class

        ENH: Adding AeroSurfaces classes

    commit f7c7a19
    Author: MateusStano <[email protected]>
    Date:   Thu Nov 3 08:06:04 2022 -0300

        ENH: add try: except: to roll

    commit e721530
    Author: MateusStano <[email protected]>
    Date:   Thu Nov 3 04:34:16 2022 -0300

        ENH: remaining TODOs

    commit edc1895
    Author: MateusStano <[email protected]>
    Date:   Thu Nov 3 04:33:46 2022 -0300

        MAINT: changed back to using trapezoidal fins with Calisto

    commit 8c0fb8a
    Author: Gui-FernandesBR <[email protected]>
    Date:   Wed Nov 2 08:17:47 2022 +0100

        ENH: adding final plots do AeroSurfaces

    commit 01819ac
    Author: Gui-FernandesBR <[email protected]>
    Date:   Wed Nov 2 08:17:12 2022 +0100

        MAINT: updating docstrings of AeroSurfaces

    commit 6b906d5
    Author: Gui-FernandesBR <[email protected]>
    Date:   Wed Nov 2 08:13:49 2022 +0100

        ENH: updating 2D plots at Function.py

    commit 57a93e7
    Author: Guilherme Fernandes Alves <[email protected]>
    Date:   Tue Nov 1 17:06:51 2022 +0100

        MAINT: removing duplicated cLift definition

        Co-authored-by: Giovani Hidalgo Ceotto <[email protected]>

    commit 024ea0f
    Author: MateusStano <[email protected]>
    Date:   Tue Nov 1 10:04:13 2022 -0300

        bug: fixed setAttribute and fin area calculation

    commit fdc5085
    Author: MateusStano <[email protected]>
    Date:   Tue Nov 1 09:25:32 2022 -0300

        enh: add setAttribute

    commit 21407f3
    Author: MateusStano <[email protected]>
    Date:   Tue Nov 1 09:11:39 2022 -0300

        enh: docs

    commit 3e18215
    Author: MateusStano <[email protected]>
    Date:   Tue Nov 1 05:41:25 2022 -0300

        enh: add allInfo() method

    commit 7e4d180
    Author: MateusStano <[email protected]>
    Date:   Tue Nov 1 05:40:58 2022 -0300

        enh: add draw() methods

    commit d898773
    Author: MateusStano <[email protected]>
    Date:   Tue Nov 1 05:39:34 2022 -0300

        enh: added super Fin class and reorganized other fin classes

    commit ea45c55
    Author: MateusStano <[email protected]>
    Date:   Tue Nov 1 05:34:48 2022 -0300

        maint: fixed wrong Yma formula in docs

    commit 2293c1c
    Author: Gui-FernandesBR <[email protected]>
    Date:   Mon Oct 24 02:13:25 2022 +0200

        FIX: adjust variables names to surpass tests

    commit eff4dc0
    Author: Gui-FernandesBR <[email protected]>
    Date:   Mon Oct 24 01:09:21 2022 +0200

        MAINT: adapting attributes names at AeroSurfaces

    commit 9dc26a3
    Author: Gui-FernandesBR <[email protected]>
    Date:   Sun Oct 23 23:00:42 2022 +0200

        MAINT: Introducing AeroSurfaces classes

    commit ba8c7bd
    Merge: 64e6a4d 2834b5f
    Author: Giovani Hidalgo Ceotto <[email protected]>
    Date:   Wed Oct 12 01:35:21 2022 -0300

        Merge pull request #256 from RocketPy-Team/enh/swept-back-fins

        ENH: Add Sweep Length to Trapezoidal Fins

    commit 2834b5f
    Author: Giovani Hidalgo Ceotto <[email protected]>
    Date:   Wed Oct 12 01:18:07 2022 -0300

        FIX: addFins returns created fin set once again

    commit af2de0c
    Author: Giovani Hidalgo Ceotto <[email protected]>
    Date:   Wed Oct 12 01:17:40 2022 -0300

        TST: implement tests related to trapezoidal fin sweep

    commit 909b38e
    Author: Giovani Hidalgo Ceotto <[email protected]>
    Date:   Wed Oct 12 00:21:14 2022 -0300

        ENH: add option to enter sweep angle in Rocket.addTrapezoidalFins

    commit 89c36c0
    Author: Giovani Hidalgo Ceotto <[email protected]>
    Date:   Wed Oct 12 00:09:54 2022 -0300

        ENH: add sweep length to trapezoidal fins

    commit 64e6a4d
    Merge: 34744af 1845d68
    Author: Guilherme Fernandes Alves <[email protected]>
    Date:   Mon Oct 10 01:24:12 2022 +0200

        Merge pull request #249 from RocketPy-Team/enh/refactor_post_process

        ENH: Introducing properties in Flight class

    commit 1845d68
    Author: Gui-FernandesBR <[email protected]>
    Date:   Sun Oct 9 17:06:39 2022 +0200

        BUG: fixing tests bugs related with lat/lon

    commit 7252bf0
    Author: Gui-FernandesBR <[email protected]>
    Date:   Sun Oct 9 03:07:39 2022 +0200

        MAINT: removing self._R1 attributes from udot

    commit cdb2093
    Author: Gui-FernandesBR <[email protected]>
    Date:   Sun Oct 9 02:35:24 2022 +0200

        MAINT: fixing tuple not callable problem

    commit 8c5f69a
    Author: Gui-FernandesBR <[email protected]>
    Date:   Sun Oct 9 02:28:43 2022 +0200

        MAINT: sorting imports

    commit 6a45586
    Author: Gui-FernandesBR <[email protected]>
    Date:   Sun Oct 9 02:23:40 2022 +0200

        DOC: updating postProcess bool in Flight.py

    commit a84cff0
    Author: Gui-FernandesBR <[email protected]>
    Date:   Sun Oct 9 02:13:56 2022 +0200

        ENH: Allow other interpolation types in properties

    commit ff665d7
    Author: Gui-FernandesBR <[email protected]>
    Date:   Sun Oct 9 02:03:05 2022 +0200

        ENH: Transform lat/lon into properties

    commit fb1a95f
    Author: Gui-FernandesBR <[email protected]>
    Date:   Sun Oct 9 01:40:58 2022 +0200

        ENH: properties for the rail buttons forces

    commit 560eb0e
    Author: Gui-FernandesBR <[email protected]>
    Date:   Sun Oct 9 01:12:01 2022 +0200

        ENH: more properties for temporary values

    commit 6656659
    Author: Gui-FernandesBR <[email protected]>
    Date:   Sun Oct 9 00:19:02 2022 +0200

        ENH: more abstract acceleration properties

    commit 34744af
    Merge: f75c7da 88e2bc2
    Author: Patrick Sampaio <[email protected]>
    Date:   Sat Oct 8 22:41:00 2022 +0200

        Merge pull request #226 from RocketPy-Team/enh/env_analysis_euroc

        WIP: ENH: Env Analysis Euroc 2022

    commit 88e2bc2
    Author: Gui-FernandesBR <[email protected]>
    Date:   Sat Oct 8 18:24:52 2022 +0200

        DOC: adding new notebook to docs page

    commit d4abe4b
    Merge: df7f927 e8da19e
    Author: Guilherme Fernandes Alves <[email protected]>
    Date:   Sat Oct 8 18:12:19 2022 +0200

        Merge pull request #197 from RocketPy-Team/enh/env_analysis_wind_direction

        ENH: Environment Analysis - Wind Heading Profiles

    commit e8da19e
    Merge: 9516619 df7f927
    Author: Gui-FernandesBR <[email protected]>
    Date:   Sat Oct 8 17:27:03 2022 +0200

        Merge remote-tracking branch 'RocketPy-Team/enh/env_analysis_euroc' into enh/env_analysis_wind_direction

    commit df7f927
    Merge: 9b9d6e6 0f070a4
    Author: Patrick Sampaio <[email protected]>
    Date:   Wed Oct 5 21:52:50 2022 +0200

        Merge pull request #244 from RocketPy-Team/enh/forecast_comparaison

        [EuroC][EnvAnalysis] add forecast comparison to env analysis

    commit 0f070a4
    Author: patrick <[email protected]>
    Date:   Wed Oct 5 21:52:28 2022 +0200

        Enh: Docs for new parameters

    commit 9b9d6e6
    Author: patrick <[email protected]>
    Date:   Tue Oct 4 12:01:50 2022 +0200

        Enh: Executed notebook

    commit eeff1cd
    Merge: 8b737b3 2002a85
    Author: patrick <[email protected]>
    Date:   Thu Sep 29 21:12:12 2022 +0200

        gMerge branch 'enh/forecast_comparaison' of https://github.com/Projeto-Jupiter/RocketPy into enh/forecast_comparaison

    commit 8b737b3
    Author: patrick <[email protected]>
    Date:   Thu Sep 29 21:12:07 2022 +0200

        MAINT: removed unused func

    commit 2002a85
    Author: Lint Action <[email protected]>
    Date:   Thu Sep 29 19:11:05 2022 +0000

        Fix code style issues with Black

    commit 145e4c5
    Merge: 2ceca6a 4e40c42
    Author: patrick <[email protected]>
    Date:   Thu Sep 29 21:10:15 2022 +0200

        Merge

    commit 2ceca6a
    Author: patrick <[email protected]>
    Date:   Thu Sep 29 21:09:21 2022 +0200

        Enh: Added windspeed forecast comparation plots and env configuration option

    commit 47b220c
    Author: Gui-FernandesBR <[email protected]>
    Date:   Thu Sep 29 04:23:57 2022 +0200

        ENH: Introducing properties in Flight class

    commit 4e40c42
    Author: Gui-FernandesBR <[email protected]>
    Date:   Tue Sep 27 16:23:42 2022 +0200

        ENH: drafting compareEnvironments method

    commit 0c63b61
    Merge: e5c920c 8bbf782
    Author: Gui-FernandesBR <[email protected]>
    Date:   Tue Sep 27 15:54:09 2022 +0200

        Merge env_analysis_euroc into forecast_comparison

    commit 9516619
    Author: Gui-FernandesBR <[email protected]>
    Date:   Tue Sep 27 15:45:24 2022 +0200

        FIX: wind heading plots title

    commit f75c7da
    Merge: be7c521 adf9414
    Author: Guilherme Fernandes Alves <[email protected]>
    Date:   Sat Sep 24 13:51:23 2022 +0200

        Merge pull request #229 from RocketPy-Team/enh/automate_dispersion

        ENH: automate dispersion inputs with csv

    commit adf9414
    Author: Gui-FernandesBR <[email protected]>
    Date:   Sat Sep 24 13:43:52 2022 +0200

        ENH: improve utilities' tests

    commit 26078c5
    Author: Guilherme Fernandes Alves <[email protected]>
    Date:   Sat Sep 24 13:30:59 2022 +0200

        FIX: Revert wrong name replace

    commit e9f1e53
    Author: Gui-FernandesBR <[email protected]>
    Date:   Sat Sep 24 13:29:12 2022 +0200

        ENH: adding tests

    commit 88d3a47
    Author: Gui-FernandesBR <[email protected]>
    Date:   Sat Sep 24 13:20:28 2022 +0200

        FIX: Refactor .csv files

    commit 5671927
    Author: Gui-FernandesBR <[email protected]>
    Date:   Sat Sep 24 13:20:10 2022 +0200

        ENH: Dealing with expect errors cases

    commit 576dc9d
    Author: Gui-FernandesBR <[email protected]>
    Date:   Sat Sep 24 04:31:35 2022 +0200

        ENH: Remove undesired sigma plots

    commit 809e815
    Merge: cee6336 8bbf782
    Author: Gui-FernandesBR <[email protected]>
    Date:   Sat Sep 24 04:23:35 2022 +0200

        GIT: Merge env_analysis_euroc into wind_direction

    commit 8bbf782
    Author: Gui-FernandesBR <[email protected]>
    Date:   Sat Sep 24 04:07:03 2022 +0200

        ADD: new notebook for EuroC example

    commit e396224
    Author: Gui-FernandesBR <[email protected]>
    Date:   Sat Sep 24 03:55:38 2022 +0200

        ENH: Modifying docs and functions attributes

    commit 6a26465
    Author: Gui-FernandesBR <[email protected]>
    Date:   Sat Sep 24 03:53:38 2022 +0200

        MAINT: Replacing with .nc files that finally works

    commit 2c065fa
    Author: Lint Action <[email protected]>
    Date:   Fri Sep 23 23:13:44 2022 +0000

        Fix code style issues with Black

    commit dae5056
    Author: Franz Masatoshi Yuri <[email protected]>
    Date:   Fri Sep 23 20:13:00 2022 -0300

        fixing errors and adding Valetudo.csv

    commit 0e8bda5
    Author: Gui-FernandesBR <[email protected]>
    Date:   Sat Sep 24 00:17:12 2022 +0200

        DOCS: changes on links website

    commit a1873e6
    Author: Gui-FernandesBR <[email protected]>
    Date:   Sat Sep 24 00:15:46 2022 +0200

        MAINT: refactor surface data file

    commit b26650b
    Merge: 68ba507 05ff066
    Author: Franz Masatoshi Yuri <[email protected]>
    Date:   Fri Sep 23 17:26:20 2022 -0300

        Merge branch 'enh/automate_dispersion' of https://github.com/RocketPy-Team/RocketPy into enh/automate_dispersion

    commit 68ba507
    Author: Franz Masatoshi Yuri <[email protected]>
    Date:   Fri Sep 23 17:23:06 2022 -0300

        removing libraries

    commit cee6336
    Merge: c39617c d4babbe
    Author: Gui-FernandesBR <[email protected]>
    Date:   Fri Sep 23 02:09:06 2022 +0200

        Merge branch 'enh/env_analysis_wind_direction' of https://github.com/rocketpy-team/rocketpy into enh/env_analysis_wind_direction

    commit c39617c
    Author: Gui-FernandesBR <[email protected]>
    Date:   Fri Sep 23 02:09:02 2022 +0200

        MAINT: REverting notebook changes

    commit d4babbe
    Merge: 2492116 58bd0c4
    Author: Guilherme Fernandes Alves <[email protected]>
    Date:   Fri Sep 23 02:05:40 2022 +0200

        Merge branch 'enh/env_analysis_euroc' into enh/env_analysis_wind_direction

    commit 58bd0c4
    Merge: cd2ba82 92acb1f
    Author: Guilherme Fernandes Alves <[email protected]>
    Date:   Fri Sep 23 01:38:06 2022 +0200

        Merge pull request #238 from RocketPy-Team/env_analysis_euroc_add_files

        ENH: Adding .nc files for EnvAnalysis at EuroC

    commit cd2ba82
    Merge: 7ecf051 0e57727
    Author: Guilherme Fernandes Alves <[email protected]>
    Date:   Fri Sep 23 01:33:13 2022 +0200

        Merge pull request #237 from RocketPy-Team/enh/env_analysis_refactor_load_files

        ENH: Refactor Env Analysis .json conversions

    commit 0e57727
    Author: Gui-FernandesBR <[email protected]>
    Date:   Fri Sep 23 01:19:38 2022 +0200

        MAINT: removing undesired comments

    commit e55ddec
    Author: Gui-FernandesBR <[email protected]>
    Date:   Fri Sep 23 01:09:14 2022 +0200

        MAINT: Add jsonpickle as requirement

    commit c5d6517
    Author: Gui-FernandesBR <[email protected]>
    Date:   Fri Sep 23 01:07:01 2022 +0200

        MAINT: Improve methods docs

    commit badea3b
    Author: Gui-FernandesBR <[email protected]>
    Date:   Fri Sep 23 01:00:15 2022 +0200

        ENH: Cleaning unused codelines

    commit ce2d65c
    Merge: 19ebc44 cda9198
    Author: Patrick Sampaio <[email protected]>
    Date:   Thu Sep 22 19:51:41 2022 +0200

        Merge pull request #239 from RocketPy-Team/enh/jsonpickle

        Enh: Using jsonpickle to serialize EnvAnal

    commit 92acb1f
    Author: Gui-FernandesBR <[email protected]>
    Date:   Thu Sep 22 16:54:41 2022 +0200

        MAINT: replacing .nc files

    commit e5c920c
    Author: patrick <[email protected]>
    Date:   Thu Sep 22 16:21:09 2022 +0200

        Enh: added forecast comparaison parameters to env analysis

    commit cda9198
    Author: patrick <[email protected]>
    Date:   Thu Sep 22 14:59:01 2022 +0200

        Enh: Using jsonpickle to serialize EnvAnal

    commit 2492116
    Merge: c7a5123 7ecf051
    Author: Guilherme Fernandes Alves <[email protected]>
    Date:   Thu Sep 22 04:23:28 2022 +0200

        Merge branch 'enh/env_analysis_euroc' into enh/env_analysis_wind_direction

    commit c7a5123
    Author: Gui-FernandesBR <[email protected]>
    Date:   Thu Sep 22 04:15:16 2022 +0200

        ENH: Improve wind heading profiles

    commit 514b882
    Merge: 03b89b8 be7c521
    Author: Gui-FernandesBR <[email protected]>
    Date:   Thu Sep 22 02:32:48 2022 +0200

        MAINT: refresh branch with master

    commit 4cc4fa4
    Author: Gui-FernandesBR <[email protected]>
    Date:   Wed Sep 21 20:54:47 2022 +0200

        ADD: EuroC Pressure Level large file

    commit 19ebc44
    Author: Gui-FernandesBR <[email protected]>
    Date:   Wed Sep 21 16:44:25 2022 +0200

        FIX: partially solve masks on json using nan

    commit c96db9d
    Author: Gui-FernandesBR <[email protected]>
    Date:   Wed Sep 21 15:46:42 2022 +0200

        MAINT: formatting with black

    commit 65d499c
    Author: Gui-FernandesBR <[email protected]>
    Date:   Wed Sep 21 15:38:58 2022 +0200

        ADD: single level file

    commit 506503d
    Author: Gui-FernandesBR <[email protected]>
    Date:   Wed Sep 21 15:37:32 2022 +0200

        ENH: Finally reading the .json correctly

    commit 9d08619
    Author: Gui-FernandesBR <[email protected]>
    Date:   Wed Sep 21 09:10:32 2022 +0200

        FIX: removing 'json' from requirements, not needed

    commit 7ecf051
    Merge: 5e6bcc4 be7c521
    Author: Gui-FernandesBR <[email protected]>
    Date:   Wed Sep 21 08:49:09 2022 +0200

        Merge remote-tracking branch 'origin/master' into enh/env_analysis_euroc

    commit cb2c2c9
    Author: Franz Masatoshi Yuri <[email protected]>
    Date:   Tue Sep 20 15:50:40 2022 -0300

        removed libraries

    commit b4f5560
    Author: Franz Masatoshi Yuri <[email protected]>
    Date:   Fri Sep 16 14:19:00 2022 -0300

        included xlsx

    commit 05ff066
    Author: FranzYuri <[email protected]>
    Date:   Thu Sep 15 13:30:49 2022 -0300

        Update utilities.py

    commit 3c89ecf
    Author: Lint Action <[email protected]>
    Date:   Tue Sep 13 23:27:24 2022 +0000

        Fix code style issues with Black

    commit 6093de3
    Author: Franz Masatoshi Yuri <[email protected]>
    Date:   Tue Sep 13 20:22:47 2022 -0300

        formating

    commit 3e0d8e5
    Merge: bc1fb76 542cd1b
    Author: Franz Masatoshi Yuri <[email protected]>
    Date:   Tue Sep 13 20:04:00 2022 -0300

        Merge branch 'enh/automate_dispersion' of https://github.com/RocketPy-Team/RocketPy into enh/automate_dispersion

    commit bc1fb76
    Author: Franz Masatoshi Yuri <[email protected]>
    Date:   Tue Sep 13 20:03:32 2022 -0300

        implemented dictionary creation

    commit 542cd1b
    Author: Franz Masatoshi Yuri <[email protected]>
    Date:   Tue Sep 13 19:54:21 2022 -0300

        implemented dictionary creation

    commit 5e6bcc4
    Author: Gui-FernandesBR <[email protected]>
    Date:   Sun Sep 11 21:35:50 2022 +0200

        MAINT: erasing unexpected conflicts

    commit d4e4b76
    Author: Lint Action <[email protected]>
    Date:   Sun Sep 11 19:28:04 2022 +0000

        Fix code style issues with Black

    commit 352073e
    Merge: 2161129 e8967cb
    Author: Gui-FernandesBR <[email protected]>
    Date:   Sun Sep 11 21:27:15 2022 +0200

        GIT: Merge conflicted branches

    commit 2161129
    Author: Gui-FernandesBR <[email protected]>
    Date:   Sun Sep 11 21:19:18 2022 +0200

        GIT: Trying to force merge

    commit be0d26c
    Author: Gui-FernandesBR <[email protected]>
    Date:   Sun Sep 11 21:14:04 2022 +0200

        MAINT: Add json to requirements

    commit e8967cb
    Author: Lint Action <[email protected]>
    Date:   Sun Sep 11 19:09:06 2022 +0000

        Fix code style issues with Black

    commit b944ce1
    Author: Gui-FernandesBR <[email protected]>
    Date:   Sun Sep 11 20:40:40 2022 +0200

        MAINT: Replace misplaced convertion units

    commit 7b24b80
    Author: Gui-FernandesBR <[email protected]>
    Date:   Sun Sep 11 19:15:28 2022 +0200

        ENH: saving EnvAnalysisDict into .json

    commit d482d96
    Author: Gui-FernandesBR <[email protected]>
    Date:   Sun Sep 11 18:21:25 2022 +0200

        MAINT: set default type json.dumps

    commit 05fb26f
    Author: Gui-FernandesBR <[email protected]>
    Date:   Sun Sep 11 18:20:42 2022 +0200

        ENH: allow to export EnvAnal profiles

    commit f5edf69
    Author: Gui-FernandesBR <[email protected]>
    Date:   Sun Sep 11 04:46:53 2022 +0200

        ENH: create exportMeanProfiles core, draft

    commit 12a2592
    Author: Gui-FernandesBR <[email protected]>
    Date:   Sun Sep 11 04:31:04 2022 +0200

        MAINT: adjust json format more beatifuly

    commit c218992
    Author: Gui-FernandesBR <[email protected]>
    Date:   Sun Sep 11 04:02:19 2022 +0200

        ENH: adding exportEnvironment method

    commit 03b89b8
    Author: Lint Action <[email protected]>
    Date:   Tue Jun 21 11:12:03 2022 +0000

        Fix code style issues with Black

    commit b2615e3
    Author: Guilherme Fernandes Alves <[email protected]>
    Date:   Tue Jun 21 08:11:39 2022 -0300

        maint: removing unused attributes

    commit f023c04
    Author: Guilherme Fernandes Alves <[email protected]>
    Date:   Tue Jun 21 08:02:24 2022 -0300

        maint: typo fix on notebook

    commit 598f6a8
    Author: Guilherme Fernandes Alves <[email protected]>
    Date:   Tue Jun 21 07:58:46 2022 -0300

        enh: adding wind headin profile to our notebook

    commit 302395a
    Author: Guilherme Fernandes Alves <[email protected]>
    Date:   Tue Jun 21 07:54:34 2022 -0300

        maint: typo fix

    commit 8b68dd8
    Author: Guilherme Fernandes Alves <[email protected]>
    Date:   Tue Jun 21 07:52:20 2022 -0300

        enh: adding new methods for wind heading plots

commit 418ddfd
Merge: 48b0fd3 7925d60
Author: MateusStano <[email protected]>
Date:   Sun Nov 13 13:50:27 2022 -0300

    Merge branch 'enh/new_plots' into enh/flight_prints

commit f5f7bca
Merge: 48b0fd3 a9f9fab
Author: Gui-FernandesBR <[email protected]>
Date:   Sun Nov 13 17:48:48 2022 +0100

    Merge branch 'master' into enh/flight_prints

commit 48b0fd3
Author: MateusStano <[email protected]>
Date:   Sun Nov 13 13:31:00 2022 -0300

    updated docs

commit ab23ce8
Author: MateusStano <[email protected]>
Date:   Sun Nov 13 13:02:56 2022 -0300

    enh: moved Flight prints to flight_prints.py
@Gui-FernandesBR Gui-FernandesBR deleted the enh/add_name_arguments branch November 17, 2022 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MateusStano MateusStano MateusStano left review comments

@giovaniceotto giovaniceotto Awaiting requested review from giovaniceotto

Assignees

@Gui-FernandesBR Gui-FernandesBR

Labels
Flight Flight Class related features
Projects
None yet
Milestone
Release v1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Gui-FernandesBR @MateusStano