Skip to content

ENH: Parachute.info() method created #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 13, 2023

Conversation

Gui-FernandesBR
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR commented Jan 24, 2023

Pull request type

Please check the type of change your PR introduces:

  • Code maintenance (refactoring, formatting, renaming, tests)

Pull request checklist

Please check if your PR fulfills the following requirements, depending on the type of PR:

  • Code base maintenance (refactoring, formatting, renaming):

    • Docs have been reviewed and added / updated if needed
    • Lint (black rocketpy) has passed locally and any fixes were made
    • All tests (pytest --runslow) have passed locally

What is the current behavior?

It is hard to plot and print information regarding the parachutes.

What is the new behavior?

Parachute class now presents more options to make or life easier when plotting everything.

Does this introduce a breaking change?

  • No

@Gui-FernandesBR Gui-FernandesBR added this to the Release v1.0.0 milestone Jan 24, 2023
@Gui-FernandesBR
Copy link
Member Author

#312

@giovaniceotto
Copy link
Member

@Gui-FernandesBR, can you fill out the PR description to better explain this PR?

I would specially like a description of the new class architecture with this new print method. Furthermore, was this framework inspired by some other work?

@Gui-FernandesBR Gui-FernandesBR changed the title Maint/extract-logic-prints ENH: Parachute.info() method created Jan 25, 2023
@Gui-FernandesBR
Copy link
Member Author

@Gui-FernandesBR, can you fill out the PR description to better explain this PR?

I would specially like a description of the new class architecture with this new print method. Furthermore, was this framework inspired by some other work?

It's filled now. I recommend starting by the #326 .

It is inspired in the #287 , see its thread for more details.

@Gui-FernandesBR Gui-FernandesBR added Enhancement New feature or request, including adjustments in current codes Parachute Related to parachutes methods and usage labels Jan 25, 2023
@Gui-FernandesBR Gui-FernandesBR linked an issue Jan 25, 2023 that may be closed by this pull request
Copy link
Member

@MateusStano MateusStano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Really like the __str__ method.

@Gui-FernandesBR Gui-FernandesBR merged commit f36f866 into beta/v1.0.0 Feb 13, 2023
@Gui-FernandesBR Gui-FernandesBR deleted the maint/extract-logic-prints branch April 10, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request, including adjustments in current codes Parachute Related to parachutes methods and usage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add parachute.info() methods
3 participants