-
-
Notifications
You must be signed in to change notification settings - Fork 194
MAINT: move last plots from Environment class #326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ready for review ✅👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good catch man! Yeah, |
Yeah, that is weird. Couldn't figure out how to fix it but found two things:
I think just removing the legend here will work |
Ready for a re-review @MateusStano |
Pull request type
Please check the type of change your PR introduces:
Pull request checklist
Please check if your PR fulfills the following requirements, depending on the type of PR:
Code base maintenance (refactoring, formatting, renaming):
black rocketpy
) has passed locally and any fixes were madepytest --runslow
) have passed locallyWhat is the new behavior?
The very same behavior, the very same results, but now there is no
plt.plot(...
inside the Enrivonment classDoes this introduce a breaking change?
Other information
This PR could be seen as an extension of #296