Fix the issue when WebP Encoding grayscale image/CMYK image #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… which cause the wrong encoded WebP image (each column repeats 3 times)
dreampiggy
force-pushed
the
bugfix_grayscale
branch
from
77c60f6 to
6693ecb
Compare
dreampiggy
changed the title
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
==========================================
- Coverage 77.11% 75.52% -1.60%
==========================================
Files 2 2
Lines 804 813 +9
==========================================
- Hits 620 614 -6
- Misses 184 199 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dreampiggy
force-pushed
the
bugfix_grayscale
branch
from
20af8cf to
1903ac2
Compare
|
This PR also fix the CMYK image's encoding issue. Test image from Apple: https://developer.apple.com/documentation/accelerate/standardizing_arbitrary_image_formats_for_processing |
dreampiggy
changed the title
This was referenced Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which cause the wrong encoded WebP image (each line repeats 3 times)
Compare
Original image:
TestImageGrayscale.jpg.zip
Before fix (Bug):
bug.webp.zip
After fix (Correct):
test.webp.zip