Skip to content

Remove Edge HTML #9166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
titusfortner opened this issue Feb 11, 2021 · 12 comments
Closed

Remove Edge HTML #9166

titusfortner opened this issue Feb 11, 2021 · 12 comments
Milestone

Comments

@titusfortner
Copy link
Member

Since Microsoft is forcing users to upgrade from Legacy Edge to the Chromium backed Edge, we've decided to remove support for it from the Selenium bindings for 4.0

Bindings maintainers can remove the label when completed in their code.

@titusfortner titusfortner added C-py Python Bindings C-rb Ruby Bindings C-dotnet .NET Bindings C-java Java Bindings C-nodejs JavaScript Bindings labels Feb 11, 2021
@titusfortner titusfortner added this to the 4.0 milestone Feb 11, 2021
@ghost ghost closed this as completed Feb 11, 2021
@titusfortner
Copy link
Member Author

thank you selenium-assistant

@titusfortner titusfortner reopened this Feb 11, 2021
@SeleniumHQ SeleniumHQ deleted a comment Feb 11, 2021
@SeleniumHQ SeleniumHQ deleted a comment Feb 11, 2021
@diemol
Copy link
Member

diemol commented Feb 11, 2021

Java done here 610b34a

@diemol diemol removed the C-java Java Bindings label Feb 11, 2021
@AutomatedTester AutomatedTester removed C-py Python Bindings C-nodejs JavaScript Bindings labels Feb 11, 2021
@titusfortner titusfortner removed the C-rb Ruby Bindings label Feb 12, 2021
@bwalderman
Copy link
Contributor

Hi @titusfortner. Support for Microsoft Edge Legacy (the browser) is indeed ending in the near future, but EdgeHTML will remain installed on the system and EdgeHTML-based universal Windows applications will continue to be supported.

Would you be open to keeping EdgeHTML support in Selenium 4? We could update the language bindings which have a UseChromium flag to true by default since Edge Chromium testing will be the most common scenario going forward.

@titusfortner
Copy link
Member Author

@bwalderman Can't you extend everything you need to work with EdgeHTML in your edge-selenium-tools project? What would you need in Selenium library to ensure it still functions correctly?

@bwalderman
Copy link
Contributor

No new changes are needed in Selenium to ensure both EdgeHTML and Chromium function correctly. The EdgeHTML support should just not be removed.

The EdgeDriver class in dotnet, python, and javascript has a UseChromium boolean property that determines whether the driver uses EdgeHTML or Chromium. At the moment, UseChromium is false by default for backward compat. I'm proposing instead of removing EdgeHTML support from all languages, we simply flip the property to true by default. This makes Edge Chromium automation easy but leaves EdgeHTML support available for those who need it. I'd be happy to submit a PR.

Regarding edge-selenium-tools, This is a polyfill for bringing Edge Chromium support to Selenium 3 because 3 is still the latest stable release. We don't intend to use edge-selenium-tools to ship new features and would prefer to contribute directly to Selenium instead. edge-selenium-tools was created as a separate project because there was no longer any vehicle for updating the official Selenium 3 with Edge Chromium support.

@titusfortner
Copy link
Member Author

Yes, all of the bindings had toggles for whether to use EdgeHTML or Edgium, and we decided in our most recent Technical Leadership Committee meeting to remove the toggles and only support the Chromium implementation going forward. EdgeHTML has always had problems because it was never completely W3C compliant, and maintaining the differences going forward will be increasingly challenging.

I suspect that projects interested in automating a universal Windows application are unlikely to also be automating the latest browsers with the same code. Setting the Selenium version to the latest 3.x version in such projects would be a better solution.

@bwalderman
Copy link
Contributor

That makes sense. After discussing with the Edge developer tools team we agree this is the cleanest solution. We'll direct anyone who needs EdgeHTML support for their legacy apps to continue using 3.x. I suspect this is a relatively small group anyway.

@titusfortner
Copy link
Member Author

@bwalderman thanks for raising the concern about this.

@AutomatedTester
Copy link
Member

I have set Chromium Edge as the default in 2b6b05b

@jimevans
Copy link
Member

I've set Chromium Edge as the default in b2a7f08

@slnksachin
Copy link

Hey, is there any tentative date, when 4.0 will be released ?
Thank you !!

valfirst added a commit to vividus-framework/vividus that referenced this issue Dec 7, 2021
valfirst added a commit to vividus-framework/vividus that referenced this issue Dec 7, 2021
@github-actions
Copy link

github-actions bot commented Jan 7, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants