Skip to content

[dotnet] Remove Edge Legacy options #9882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

bwalderman
Copy link
Contributor

Description

This change removes the UseChromium property from EdgeOptions, and removes leftover EdgeHTML-only properties and methods that no longer have any effect with the Chromium EdgeDriver.

Motivation and Context

In #9166 the decision was made to remove EdgeHTML support from Selenium 4. Capabilities that were only applicable to MicrosoftWebDriver (EdgeHTML) can safely be removed. Now that Edge Chromium is the default and only supported Edge version, the UseChromium switch and the related EdgeDriverService constructors can be removed as well.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@titusfortner titusfortner added the C-dotnet .NET Bindings label Oct 4, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jimevans
Copy link
Member

Merged in d3b35ef. Thank you for the contribution.

@jimevans jimevans closed this Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-dotnet .NET Bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants