Skip to content

optimize scanning of vulkan shader files in ncnn_add_layer() #6019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025

Conversation

maxint
Copy link
Contributor

@maxint maxint commented Apr 25, 2025

用 cmake version 3.24.2 在 Ubuntu-16.04 下 cmake configure 很卡,需要优化下

@github-actions github-actions bot added the cmake label Apr 25, 2025
@tencent-adm
Copy link
Member

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@nihui nihui requested a review from Copilot April 25, 2025 03:30
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • cmake/ncnn_add_layer.cmake: Language not supported

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.52%. Comparing base (71ed023) to head (f28ce69).
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6019       +/-   ##
===========================================
+ Coverage   94.43%   95.52%    +1.08%     
===========================================
  Files         468      825      +357     
  Lines      133738   269647   +135909     
===========================================
+ Hits       126289   257567   +131278     
- Misses       7449    12080     +4631     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

The binary size change of libncnn.so (bytes)

architecture base size pr size difference
x86_64 16465128 16465128 0 😘
armhf 7335260 7335260 0 😘
aarch64 10704800 10704800 0 😘

@nihui nihui merged commit 501d235 into Tencent:master Apr 25, 2025
79 of 82 checks passed
@nihui
Copy link
Member

nihui commented Apr 25, 2025

Thanks for your contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants