fix: use SampleSH and set envLightColor as first light (#396) #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could I have some info about what actually fail here? |
It is our internal CI process, which needs to be updated. |
H3idi-X
reviewed
Apr 14, 2025
There was a problem hiding this comment.
It looks SampleSH(normalDirection) is not added to float3 envLightColor unlike DoubleShadeeWithFeather.
H3idi-X
reviewed
Apr 14, 2025
There was a problem hiding this comment.
I understand that we should adopt saturate() instead of the former ones.
H3idi-X
reviewed
Apr 14, 2025
H3idi-X
added a commit
that referenced
this pull request
Apr 14, 2025
|
@Thaina thank you for your contribution and the PR. We greatly appreciate your effort in raising the issue and providing a solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.