Skip to content

calling InitializeBacedGIData() is necessary for newer than 6000.0.12. #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2025

Conversation

H3idi-X
Copy link
Collaborator

@H3idi-X H3idi-X commented Apr 30, 2025

This PR is a fix for #395.
This issue started from Unity 60000.0.12f1, the initialization process in URP lit shaders is now separated, as shown here:
https://github.com/Unity-Technologies/Graphics/blame/master/Packages/com.unity.render-pipelines.universal/Shaders/BakedLitForwardPass.hlsl#L171

Because of this change, we'll need to add code to initialize GI.

@H3idi-X H3idi-X changed the title calling InitializeBacedGIData() is necessary for newer than 6000.0.0. calling InitializeBacedGIData() is necessary for newer than 6000.0.12. Apr 30, 2025
@H3idi-X H3idi-X marked this pull request as ready for review May 1, 2025 01:46
@H3idi-X H3idi-X requested review from karasusan and sindharta May 1, 2025 01:48
@H3idi-X H3idi-X merged commit a125771 into development/v1 May 1, 2025
45 checks passed
@H3idi-X H3idi-X deleted the dev/fix395-init-gi branch May 1, 2025 07:40
@karasusan karasusan restored the dev/fix395-init-gi branch June 17, 2025 02:25
@H3idi-X H3idi-X deleted the dev/fix395-init-gi branch June 17, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants