Skip to content

test: update all TestProjects for Unity6 to use Unity 6000.0.48 #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
May 9, 2025
Merged

test: update all TestProjects for Unity6 to use Unity 6000.0.48 #416

merged 23 commits into from
May 9, 2025

Conversation

sindharta
Copy link
Collaborator

No description provided.

@sindharta sindharta requested review from H3idi-X and karasusan May 2, 2025 11:30
@sindharta sindharta marked this pull request as ready for review May 2, 2025 11:30
@karasusan
Copy link

There is an error in the HDRP wizard window when opening the project on macOS.
image

H3idi-X
H3idi-X approved these changes May 8, 2025
View reviewed changes
Copy link
Collaborator

@H3idi-X H3idi-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I observed dialog poping up for light map data as @karasusan mentioned, though, I understand they don't affect to the results of the graphic tests. I confirmed all the tests for 6000.0 is updated to be based on 6000.0.48f1.

@sindharta-tanuwijaya
Copy link

@karasusan
Thank you.
The PR is ready for review again.

@karasusan
Copy link

karasusan commented May 9, 2025 •
edited
Loading

I tried to test HdrpDX12GraphicsTest-6000.0 with Windows standalone, but the build process failed. The test for Playmode was all green.
I don't think this PR is the reason for this failure, but I want to confirm it if possible.
image

karasusan
karasusan approved these changes May 9, 2025
View reviewed changes
Copy link

@karasusan karasusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The standalone test failed, but this PR is not the reason

@sindharta
Copy link
Collaborator Author

I tried to test HdrpDX12GraphicsTest-6000.0 with Windows standalone, but the build process failed. The test for Playmode was all green.

Thank you for bringing that up.
This is something to fix in a different PR.

@sindharta-tanuwijaya sindharta-tanuwijaya merged commit 86f18e5 into development/v1 May 9, 2025
33 checks passed
@sindharta-tanuwijaya sindharta-tanuwijaya deleted the unity6-update branch May 9, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karasusan karasusan karasusan approved these changes

@H3idi-X H3idi-X H3idi-X approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sindharta @karasusan @sindharta-tanuwijaya @H3idi-X