Skip to content

[ISSUE #9351] Add topic-group mapping in queryTopicConsumeByWho command #9352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

golden-yang
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #9351

Brief Description

Add a simple cache in ConsumerManager to avoid traversing the map for each query

How Did You Test This Change?

In our internally maintained version of RocketMQ, this functionality and performance have been verified.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 47.95%. Comparing base (854369a) to head (104366d).

Files with missing lines Patch % Lines
...apache/rocketmq/broker/client/ConsumerManager.java 66.66% 5 Missing and 5 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9352      +/-   ##
=============================================
- Coverage      48.04%   47.95%   -0.10%     
+ Complexity     12142    12122      -20     
=============================================
  Files           1323     1323              
  Lines          93395    93417      +22     
  Branches       11997    12004       +7     
=============================================
- Hits           44875    44800      -75     
- Misses         42971    43052      +81     
- Partials        5549     5565      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lizhimins lizhimins changed the title improve: add topic-group cache in queryTopicConsumeByWho [ISSUE #9351] Add topic-group mapping in queryTopicConsumeByWho command Apr 22, 2025
@lizhimins lizhimins merged commit 7ef3610 into apache:develop Apr 23, 2025
10 of 11 checks passed
3424672656 pushed a commit to 3424672656/rocketmq that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Optimize the performance of the queryTopicConsumeByWho
3 participants