[ISSUE #9352] Fix wrong value in topic-group cache #9424
Merged
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: goldenyang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9424 +/- ##
=============================================
- Coverage 47.92% 47.90% -0.02%
- Complexity 11894 11895 +1
=============================================
Files 1307 1307
Lines 92021 92021
Branches 11775 11775
=============================================
- Hits 44097 44080 -17
- Misses 42432 42454 +22
+ Partials 5492 5487 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lizhimins
approved these changes
May 30, 2025
lizhimins
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes wrong value in topic-group cache when registerConsumer #9352
Brief Description
In our use case, we used other methods to manage topic-group mapping, so we missed the test here.
How Did You Test This Change?
In this PR, the unit test is improved, which not only verifies whether the returned result is empty, but also verifies whether the specific value is correct.