set encoding to utf-8 when no encoding is specified when reading/writing to s3 #1257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
jaidisido
approved these changes
Apr 6, 2022
There was a problem hiding this comment.
I agree with the premise that utf-8 could be a sane default here.
Instead of fixing it in every call however, we should probably consider fixing the issue at the source. It seems that utf-8 is already set as a default but at the method parameter level which is an anti-pattern. It should instead be defined within the method itself
kukushking
approved these changes
Apr 12, 2022
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
athena.read_sql_querywithctas_approach=Falseand column names containing special characters fails with anUnicodeDecodeError. When setting the encoding to utf-8 the error is gone.pandas_kwargs(or just anencodingargument) all the way up to read_sql_query may not be the best course of action given how utf-8 is widespread nowadays and Athena-own support of other encodings may be lacking and not working as intended. On the other hand, utf-8 can largely be considered the default and this change is unlikely to cause side-effects. I'm happy to discuss this decision though!Relates
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.