Skip to content

set encoding to utf-8 when no encoding is specified when reading/writing to s3 #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 12, 2022
Merged

set encoding to utf-8 when no encoding is specified when reading/writing to s3 #1257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8135053
set encoding to utf-8 when no encoding is specified when reading/writ…
cnfait Apr 5, 2022
af76f24
Merge branch 'main' into windows-unicodedecodeerror
jaidisido Apr 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion awswrangler/s3/_read_text.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def _get_read_details(path: str, pandas_kwargs: Dict[str, Any]) -> Tuple[str, Op
if pandas_kwargs.get("compression", "infer") == "infer":
pandas_kwargs["compression"] = infer_compression(path, compression="infer")
mode: str = "r" if pandas_kwargs.get("compression") is None else "rb"
encoding: Optional[str] = pandas_kwargs.get("encoding", None)
encoding: Optional[str] = pandas_kwargs.get("encoding", "utf-8")
newline: Optional[str] = pandas_kwargs.get("lineterminator", None)
return mode, encoding, newline

Expand Down
2 changes: 1 addition & 1 deletion awswrangler/s3/_write_text.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def _get_write_details(path: str, pandas_kwargs: Dict[str, Any]) -> Tuple[str, O
if pandas_kwargs.get("compression", "infer") == "infer":
pandas_kwargs["compression"] = infer_compression(path, compression="infer")
mode: str = "w" if pandas_kwargs.get("compression") is None else "wb"
encoding: Optional[str] = pandas_kwargs.get("encoding", None)
encoding: Optional[str] = pandas_kwargs.get("encoding", "utf-8")
newline: Optional[str] = pandas_kwargs.get("lineterminator", "")
return mode, encoding, newline

Expand Down