[FIX] Replace colorpalette and other necessary fixes #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimozGodec
force-pushed
the
colorpalettes
branch
from
f037f8a to
4457c74
Compare
PrimozGodec
force-pushed
the
colorpalettes
branch
2 times, most recently
from
2e384b6 to
b0d22b7
Compare
PrimozGodec
force-pushed
the
colorpalettes
branch
from
b0d22b7 to
2f9ef69
Compare
PrimozGodec
changed the title
PrimozGodec
force-pushed
the
colorpalettes
branch
5 times, most recently
from
1deceb5 to
6dc952f
Compare
PrimozGodec
force-pushed
the
colorpalettes
branch
2 times, most recently
from
e5e975b to
5b9be1a
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #314 +/- ##
==========================================
+ Coverage 48.51% 48.98% +0.46%
==========================================
Files 63 63
Lines 10765 10797 +32
==========================================
+ Hits 5223 5289 +66
+ Misses 5542 5508 -34
Continue to review full report at Codecov.
|
PrimozGodec
force-pushed
the
colorpalettes
branch
from
5b9be1a to
1d78a23
Compare
PrimozGodec
force-pushed
the
colorpalettes
branch
from
1d78a23 to
dd0eeb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Annotator use colorpalette which is deprecated biolab/orange3#6135
Because of changes in Orange (mostly Table lock), some widgets/tests do not work.
Description of changes
Use colorpalettes module instead
Necessary fixes for widgets/tests to work:
effective_datato match other widgets (and I think it is now more correct than before). It was necessary to fix it due to a failing test caused by the change in core Orange. If I understand effective_data correctly, are those data currently plotted as x and y, and if they do not change, replot is unnecessary.Includes