Skip to content

Remove deprecated colorbrewer and colorpalette #6135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

PrimozGodec
Copy link
Contributor

Issue

I just randomly found the colorbrewer and saw it is deprecated for a very long time. I think it is time to remove it.

Description of changes

Since colorbrewer and colorpalette are deprecated for long enough I propose deleting them.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #6135 (b21b5d5) into master (2f2ca12) will increase coverage by 0.52%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6135      +/-   ##
==========================================
+ Coverage   86.46%   86.98%   +0.52%     
==========================================
  Files         315      313       -2     
  Lines       67607    66971     -636     
==========================================
- Hits        58456    58255     -201     
+ Misses       9151     8716     -435     

@janezd
Copy link
Contributor

janezd commented Sep 12, 2022

I welcome removal of colorpalette because I always have to check whether to use colorpalette or colorpalettes.

I hope, though, that no-addons use it. Have you checked? (I don't have single cell and a few others.)

@PrimozGodec
Copy link
Contributor Author

I have believed it is already removed from add-ons since colorpalettes has been deprecated for two years, but that is not the case. It is still used in geo (tests only), bioinformatics, and image analytics. So this PR will need to sit here for a while before it can be merged.

I am working on replacing it with colorpalettes.

@janezd
Copy link
Contributor

janezd commented Sep 12, 2022

I have believed it is already removed from add-ons since colorpalettes has been deprecated for two years, but that is not the case.

A s' ti nov tuki?

Still, it's a good that you created this PR, so that we show that deprecation is meant seriously and is coming. :)

@PrimozGodec
Copy link
Contributor Author

By the way, I think that failing the pyqt6 tests are caused by changes in orangewidgetbase (it started to fail after the release). I cannot reproduce it localy.

@PrimozGodec
Copy link
Contributor Author

I created a release of Image Analytics with colorpalette changes that users start to update to the new version. Geo does not need to be released -- only tests were fixed there. At Bioinformatic, fixes are merged, but it must be released before we merge this PR.

After Bioinformatics is released, I suggest waiting a bit before merging this PR so that more users update the addons (maybe we merge this PR after Orange 3.34 is released).

@janezd janezd marked this pull request as ready for review December 23, 2022 08:18
@janezd janezd self-assigned this Dec 23, 2022
@markotoplak markotoplak merged commit 8503121 into biolab:master Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants