-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Remove deprecated colorbrewer and colorpalette #6135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6135 +/- ##
==========================================
+ Coverage 86.46% 86.98% +0.52%
==========================================
Files 315 313 -2
Lines 67607 66971 -636
==========================================
- Hits 58456 58255 -201
+ Misses 9151 8716 -435 |
I welcome removal of I hope, though, that no-addons use it. Have you checked? (I don't have single cell and a few others.) |
I have believed it is already removed from add-ons since I am working on replacing it with colorpalettes. |
A s' ti nov tuki? Still, it's a good that you created this PR, so that we show that deprecation is meant seriously and is coming. :) |
By the way, I think that failing the pyqt6 tests are caused by changes in orangewidgetbase (it started to fail after the release). I cannot reproduce it localy. |
I created a release of Image Analytics with colorpalette changes that users start to update to the new version. Geo does not need to be released -- only tests were fixed there. At Bioinformatic, fixes are merged, but it must be released before we merge this PR. After Bioinformatics is released, I suggest waiting a bit before merging this PR so that more users update the addons (maybe we merge this PR after Orange 3.34 is released). |
Issue
I just randomly found the
colorbrewer
and saw it is deprecated for a very long time. I think it is time to remove it.Description of changes
Since
colorbrewer
andcolorpalette
are deprecated for long enough I propose deleting them.Includes