Skip to content

Eliminate domain registration step from samples because Cadence comes with 'default' domain now #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2025
Merged

Eliminate domain registration step from samples because Cadence comes with 'default' domain now #89

merged 1 commit into from
May 5, 2025

Conversation

taylanisikdemir
Copy link
Member

@taylanisikdemir taylanisikdemir commented May 1, 2025 •
edited
Loading

Cadence local docker-compose setup has a builtin domain default which is added in cadence-workflow/cadence#6619.

This PR removes samples-domain registration steps to make it slightly easier to try Cadence for the first time.

Tested by running make and a few samples mentioned in README file.

ibarrajo
ibarrajo approved these changes May 5, 2025
View reviewed changes
Copy link
Contributor

@ibarrajo ibarrajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚀

@taylanisikdemir taylanisikdemir merged commit 900008a into cadence-workflow:master May 5, 2025
1 check passed
@taylanisikdemir taylanisikdemir deleted the taylan/eliminate_domain_register branch May 5, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibarrajo ibarrajo ibarrajo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taylanisikdemir @ibarrajo