Register 'default' domain during auto-setup image startup #6619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samkitshah1262
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
|
Hi @taylanisikdemir ! requested changes have been applied and tested. Also updated steps for reproduction. Thanks :) |
samkitshah1262
changed the title
taylanisikdemir
approved these changes
Feb 6, 2025
taylanisikdemir
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Domain set up is now done through the docker image itself. No extra steps needed.
Steps to reproduce:
Build the auto-setup image at the root
docker build . -f Dockerfile -t ubercadence/server:master-auto-setup --build-arg TARGET=auto-setupRun the docker container from the docker folder
docker-compose upthe domain data is directly being inserted into the respective database
Towards #2343
Locally
Docker auto-setup image can be corrupted
Release notes
Documentation Changes