Skip to content

Remove out-of-date translated docs #2074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Conversation

MasterOdin
Copy link
Member

@MasterOdin MasterOdin commented Mar 9, 2022

The es, fr, and jp translations, while nice to have in theory, are so far out of date to probably be detrimental. Without either a larger contributor community around phinx, or a regular maintainer willing to dedicate to maintaining these docs, I see no reason to keep them and let them grow more and more out of date.

As such, this PR removes the pages as well as building them altogether from phinx. While it's regrettable, at least no one will risk getting docs that are flat out wrong for something phinx does or supports.

Copy link
Member

@dereuromark dereuromark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with it, but we also need to ask the rest of the team here.

@aspirantzhang
Copy link

I have seen that .rst files can be translated "line by line" using .po files. I think this is a good solution. I wonder why CakePHP doesn't take this approach?
However, in the process of working with Chinese documents, I also found that files in other languages were missing a lot of content, so it might be a good idea to delete them all.

@markstory
Copy link
Member

I have seen that .rst files can be translated "line by line" using .po files. I think this is a good solution. I wonder why CakePHP doesn't take this approach?

The main reason I didn't go down this path was having to sync every update made to the english docs to all the po files. I wanted the docs to be 'easy' to contribute to, and trying to convince occasional contributors to also update a PO file didn't feel like a smooth process. Using PO files doesn't address the content going out of date either, so it felt like a lot of extra work for little benefit.

I also found that files in other languages were missing a lot of content, so it might be a good idea to delete them all.

If the docs are outdated and we have no maintainers, removing the docs translations is reasonable. Better that folks use google translate to view the content vs reading potentially wrong information.

@dereuromark dereuromark merged commit ce4a803 into master Mar 9, 2022
@dereuromark dereuromark deleted the remove_translated_docs branch March 9, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants