Skip to content

[Bug]: logical error in command line argument check #4474

Open
@humblemat810

Description

@humblemat810

What happened?

.venv/lib/python3.10/site-packages/chromadb/cli/cli.py
line 50
if ["chroma", "update"] in args:
update()
return
I believe you are trying to say if both of the arguments are in the argument list
a possible correction should be:
if all(i in args for i in ["chroma", "update"]):
update()
return

I tried to see if it is new python syntax but it seems not, see example below:
{list of arg} in {list of arg} does not work
[1,2] in [2, 3]
False
[1,2] in [2, 3,1]
False
[1,2] in [2, 3,1,2]
False
[1,2] in [1,2]
False

Versions

chroma --version
chroma 1.0.0

Relevant log output

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions