Skip to content

[BUG] Correctly check arguments for chroma cli for chroma update #4713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

priyankc
Copy link

@priyankc priyankc commented Jun 2, 2025

Description of changes

When a user runs chroma update from the command line, the code should detect this command and run the update() function to check for newer versions of Chroma. It is incorrectly checking for the command line arguments

Test plan

pip install -e .

python3 -c "import sys; from chromadb.cli import cli; sys.argv = ['chroma', 'update']; cli.app()"

  • Doesn't trigger chroma update. You will see a wrong message:
image
  • Run the above with fix, you will see update run correctly.
image
  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Fixes #4474

Copy link

github-actions bot commented Jun 2, 2025

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor

This PR corrects the logic used to detect the 'chroma update' command in the CLI, ensuring that the update() function is triggered when users invoke 'chroma update' from the command line. The previous implementation failed to recognize the command due to improper argument checking, which is now fixed by explicitly checking the first two sys.argv values.

This summary was automatically generated by @propel-code-bot

@priyankc
Copy link
Author

priyankc commented Jun 2, 2025

@itaismith I mistakenly created the PR against my fork.

This is the right PR.

@priyankc
Copy link
Author

priyankc commented Jun 4, 2025

@itaismith Looks like the CI failures are not relevant to this PR. Is there anything else blocking this PR landing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: logical error in command line argument check
2 participants