[CLN]: split up log impls into separate files #3575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jan 28, 2025
codetheweb
force-pushed
the
cln-split-log-impls
branch
from
2379f89 to
e0312e9
Compare
codetheweb
force-pushed
the
cln-split-log-impls
branch
from
e0312e9 to
4d42e16
Compare
1 task
codetheweb
force-pushed
the
cln-split-log-impls
branch
from
4d42e16 to
bc54aac
Compare
rescrv
approved these changes
Jan 28, 2025
Comment on lines
+18
to
+27
| impl Debug for InternalLogRecord { | ||
| fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { | ||
| f.debug_struct("LogRecord") | ||
| .field("collection_id", &self.collection_id) | ||
| .field("log_offset", &self.log_offset) | ||
| .field("log_ts", &self.log_ts) | ||
| .field("record", &self.record) | ||
| .finish() | ||
| } | ||
| } |
There was a problem hiding this comment.
This looks as good as Derive. Any reason for manual impl?
There was a problem hiding this comment.
I'm not sure, Derive seems fine. Leaving as-is in this PR to avoid code change & re-org in the same PR.
Comment on lines
+63
to
+64
| offset: i64, | ||
| batch_size: i32, |
There was a problem hiding this comment.
Do these have to be signed?
There was a problem hiding this comment.
No, but they're also signed in the proto. Leaving as-is in this PR to avoid code change & re-org in the same PR.
| pub(super) async fn update_collection_log_offset( | ||
| &mut self, | ||
| collection_id: CollectionUuid, | ||
| new_offset: i64, |
There was a problem hiding this comment.
Does this have to be signed?
There was a problem hiding this comment.
See above comment.
codetheweb
force-pushed
the
cln-split-log-impls
branch
from
bc54aac to
e511313
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
No logic changes, just split up the single file that had both the in-memory and grpc log impls.
Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?
n/a