Skip to content

[ENH]: add /add route to Rust frontend #3590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

codetheweb
Copy link
Contributor

@codetheweb codetheweb commented Jan 28, 2025

Description of changes

Adds write path to Rust frontend.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Tested with a small script that added records and then queried them.

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

n/a

Copy link
Contributor Author

codetheweb commented Jan 28, 2025

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@codetheweb codetheweb changed the title [ENH]: add /add to Rust frontend [ENH]: add /add route to Rust frontend Jan 28, 2025
@codetheweb codetheweb force-pushed the feat-rust-frontend-log-write branch 2 times, most recently from b9a9663 to b7c3306 Compare January 28, 2025 22:33
metadata: Some(metadata),
operation: Operation::Add,
});
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can maybe extract this out into a helper when we add update/upsert

@codetheweb codetheweb marked this pull request as ready for review January 28, 2025 22:34
@codetheweb codetheweb force-pushed the feat-log-interface-push-logs branch from 0d7ffbc to eff727f Compare January 28, 2025 22:42
@codetheweb codetheweb force-pushed the feat-rust-frontend-log-write branch from b7c3306 to 1a76d9f Compare January 28, 2025 22:42
@codetheweb codetheweb force-pushed the feat-log-interface-push-logs branch from eff727f to 206fb61 Compare January 28, 2025 23:07
@codetheweb codetheweb force-pushed the feat-rust-frontend-log-write branch from 1a76d9f to 5c3f1ea Compare January 28, 2025 23:07
@codetheweb codetheweb force-pushed the feat-rust-frontend-log-write branch from 5c3f1ea to 98b7db3 Compare January 28, 2025 23:46
Copy link
Contributor Author

codetheweb commented Jan 29, 2025

Merge activity

  • Jan 28, 7:36 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 28, 8:27 PM EST: Graphite couldn't merge this PR because it had conflicts with the trunk branch.
  • Jan 28, 8:28 PM EST: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

@codetheweb codetheweb changed the base branch from feat-log-interface-push-logs to graphite-base/3590 January 29, 2025 00:38
@codetheweb codetheweb changed the base branch from graphite-base/3590 to main January 29, 2025 01:26
@codetheweb codetheweb force-pushed the feat-rust-frontend-log-write branch from 98b7db3 to b4a5bbb Compare January 29, 2025 01:33
@codetheweb codetheweb enabled auto-merge (squash) January 29, 2025 01:33
@codetheweb codetheweb merged commit e038c74 into main Jan 29, 2025
91 checks passed
@codetheweb codetheweb deleted the feat-rust-frontend-log-write branch January 29, 2025 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants