-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[ENH]: add /add
route to Rust frontend
#3590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 28, 2025
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
/add
route to Rust frontend
b9a9663
to
b7c3306
Compare
codetheweb
commented
Jan 28, 2025
metadata: Some(metadata), | ||
operation: Operation::Add, | ||
}); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can maybe extract this out into a helper when we add update/upsert
0d7ffbc
to
eff727f
Compare
b7c3306
to
1a76d9f
Compare
eff727f
to
206fb61
Compare
1a76d9f
to
5c3f1ea
Compare
rescrv
approved these changes
Jan 28, 2025
5c3f1ea
to
98b7db3
Compare
Merge activity
|
98b7db3
to
b4a5bbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds write path to Rust frontend.
Test plan
How are these changes tested?
pytest
for python,yarn test
for js,cargo test
for rustTested with a small script that added records and then queried them.
Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?
n/a