Skip to content

[ENH] return configuration in server response #4087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 18, 2025

Conversation

jairad26
Copy link
Contributor

@jairad26 jairad26 commented Mar 25, 2025

Description of changes

  • Improvements & Bug fixes
    • Removed #[serde(skip_serializing)] attribute from config field in Collection struct, allowing it to be serialized
    • Added ToSchema derive macro to VectorIndexConfiguration enum, enabling OpenAPI schema generation
    • Added ToSchema derive macro to InternalCollectionConfiguration struct for OpenAPI schema generation
    • Added ToSchema derive macro to InternalSpannConfiguration struct for OpenAPI schema generation
    • Add ability to deserialize into the correct CollectionConfiguration type, add backwards compatiblity for new clients talking to old servers

Test plan

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

No documentation changes required as these changes are related to internal serialization and schema generation capabilities.

Copy link

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor Author

jairad26 commented Mar 25, 2025

@jairad26 jairad26 marked this pull request as ready for review March 25, 2025 23:47
@jairad26 jairad26 marked this pull request as draft March 25, 2025 23:48
@jairad26 jairad26 changed the title server-coll-config-response [ENH] server-coll-config-response Mar 25, 2025
@jairad26 jairad26 changed the title [ENH] server-coll-config-response [ENH] return configuration in server response Mar 25, 2025
@jairad26 jairad26 force-pushed the 03-25-server-coll-config-response branch from 5372cf9 to 09633ee Compare April 4, 2025 00:42
@jairad26 jairad26 force-pushed the jai/coll-config-http-grpc branch from 08c9a4f to 3c89ad8 Compare April 4, 2025 00:42
@jairad26 jairad26 force-pushed the 03-25-server-coll-config-response branch 2 times, most recently from acd5203 to 5faaf90 Compare April 4, 2025 23:10
@jairad26 jairad26 force-pushed the jai/coll-config-http-grpc branch from 3c89ad8 to f1aea74 Compare April 4, 2025 23:10
@jairad26 jairad26 force-pushed the 03-25-server-coll-config-response branch from 5faaf90 to 7fbe31e Compare April 5, 2025 23:24
@jairad26 jairad26 force-pushed the jai/coll-config-http-grpc branch from f1aea74 to 7334a3f Compare April 5, 2025 23:24
@jairad26 jairad26 marked this pull request as ready for review April 5, 2025 23:26
@jairad26 jairad26 force-pushed the 03-25-server-coll-config-response branch from 7fbe31e to 95c4dbb Compare April 7, 2025 17:15
@jairad26 jairad26 force-pushed the jai/coll-config-http-grpc branch from 7334a3f to c645969 Compare April 7, 2025 17:15
@jairad26 jairad26 force-pushed the 03-25-server-coll-config-response branch from 95c4dbb to 59b49f0 Compare April 7, 2025 17:15
@jairad26 jairad26 force-pushed the 03-25-server-coll-config-response branch from 59b49f0 to f06fbcd Compare April 7, 2025 17:34
@jairad26 jairad26 force-pushed the jai/coll-config-http-grpc branch from c645969 to 9d1ec6d Compare April 7, 2025 17:34
@jairad26 jairad26 force-pushed the jai/coll-config-http-grpc branch from 9d1ec6d to f920887 Compare April 8, 2025 16:07
@jairad26 jairad26 force-pushed the 03-25-server-coll-config-response branch 2 times, most recently from 3605211 to ddde3db Compare April 8, 2025 17:31
@jairad26 jairad26 force-pushed the jai/coll-config-http-grpc branch from f920887 to fb1d960 Compare April 8, 2025 17:31
@jairad26 jairad26 force-pushed the 03-25-server-coll-config-response branch from ddde3db to af072d7 Compare April 8, 2025 22:14
@jairad26 jairad26 force-pushed the 03-25-server-coll-config-response branch from b29f535 to 755024e Compare April 15, 2025 22:32
@jairad26 jairad26 force-pushed the jai/coll-config-http-grpc branch from e7dbe8b to 247c330 Compare April 15, 2025 22:32
@jairad26 jairad26 force-pushed the 03-25-server-coll-config-response branch from 755024e to fe2e03d Compare April 16, 2025 17:20
@jairad26 jairad26 force-pushed the jai/coll-config-http-grpc branch from 247c330 to 27d7e2d Compare April 16, 2025 17:20
@jairad26 jairad26 force-pushed the 03-25-server-coll-config-response branch from fe2e03d to 7976b61 Compare April 16, 2025 17:34
@jairad26 jairad26 force-pushed the jai/coll-config-http-grpc branch from 27d7e2d to 8896527 Compare April 16, 2025 17:34
@jairad26 jairad26 force-pushed the jai/coll-config-http-grpc branch from 8896527 to 77d19d4 Compare April 16, 2025 17:38
@jairad26 jairad26 force-pushed the 03-25-server-coll-config-response branch 2 times, most recently from 69ef0ab to 7329be6 Compare April 16, 2025 17:53
@jairad26 jairad26 force-pushed the jai/coll-config-http-grpc branch 2 times, most recently from 09bad86 to 4b5fc93 Compare April 16, 2025 17:56
@jairad26 jairad26 force-pushed the 03-25-server-coll-config-response branch from 7329be6 to 0bcaab3 Compare April 16, 2025 17:56
@jairad26 jairad26 changed the base branch from jai/coll-config-http-grpc to graphite-base/4087 April 16, 2025 20:52
@jairad26 jairad26 force-pushed the 03-25-server-coll-config-response branch from 0bcaab3 to c81195e Compare April 16, 2025 20:57
@jairad26 jairad26 force-pushed the graphite-base/4087 branch from 4b5fc93 to 10f450d Compare April 16, 2025 20:57
@jairad26 jairad26 changed the base branch from graphite-base/4087 to jai/coll-config-http-grpc April 16, 2025 20:57
@jairad26 jairad26 force-pushed the 03-25-server-coll-config-response branch from c81195e to 13b7424 Compare April 16, 2025 21:00
@jairad26 jairad26 mentioned this pull request Apr 16, 2025
1 task
@jairad26 jairad26 force-pushed the jai/coll-config-http-grpc branch from 10f450d to 9f394e1 Compare April 17, 2025 20:09
@jairad26 jairad26 force-pushed the 03-25-server-coll-config-response branch 3 times, most recently from f464c51 to 4b4277d Compare April 17, 2025 21:42
@jairad26 jairad26 force-pushed the 03-25-server-coll-config-response branch from 4b4277d to f3ec5a5 Compare April 18, 2025 00:32
@jairad26 jairad26 force-pushed the jai/coll-config-http-grpc branch from 9f394e1 to 161ea0f Compare April 18, 2025 00:32
@jairad26 jairad26 changed the base branch from jai/coll-config-http-grpc to main April 18, 2025 01:27
@jairad26 jairad26 merged commit ad0609b into main Apr 18, 2025
128 of 137 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants