Skip to content

[ENH] Add collection config to js client #4116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2025
Merged

[ENH] Add collection config to js client #4116

merged 1 commit into from
Apr 18, 2025

Conversation

jairad26
Copy link
Contributor

@jairad26 jairad26 commented Mar 30, 2025 •
edited
Loading

Description of changes

This PR adds support for collection configuration in the javascript client. it updates tests, functionality, and introduces a breaking change involving how the rust server responds with include

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@jairad26 Graphite App
Copy link
Contributor Author

jairad26 commented Mar 30, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jairad26 jairad26 mentioned this pull request Mar 30, 2025
Merged
1 task
@jairad26 jairad26 force-pushed the jai/js-coll-config branch from 018f5c5 to 0eb195f Compare March 31, 2025 18:30
@jairad26 jairad26 force-pushed the jai/js-client-regen branch 2 times, most recently from 94455b3 to d7f02af Compare March 31, 2025 23:24
@jairad26 jairad26 force-pushed the jai/js-coll-config branch from 0eb195f to 036f965 Compare March 31, 2025 23:25
@jairad26 jairad26 force-pushed the jai/js-client-regen branch from d7f02af to 1916cd7 Compare March 31, 2025 23:29
@jairad26 jairad26 force-pushed the jai/js-coll-config branch from 036f965 to acffcaa Compare March 31, 2025 23:29
@jairad26 jairad26 force-pushed the jai/js-client-regen branch from 1916cd7 to afcbcaf Compare April 1, 2025 16:28
@jairad26 jairad26 force-pushed the jai/js-coll-config branch from acffcaa to c3c5ed8 Compare April 1, 2025 16:28
@jairad26 jairad26 force-pushed the jai/js-client-regen branch from afcbcaf to 1ba4def Compare April 1, 2025 16:36
@jairad26 jairad26 force-pushed the jai/js-coll-config branch from c3c5ed8 to d2b2673 Compare April 1, 2025 16:36
@jairad26 jairad26 force-pushed the jai/js-client-regen branch from 1ba4def to b0fd83b Compare April 1, 2025 16:43
@jairad26 jairad26 force-pushed the jai/js-coll-config branch 2 times, most recently from bceae27 to bf41525 Compare April 1, 2025 16:51
@jairad26 jairad26 force-pushed the jai/js-client-regen branch 2 times, most recently from 13ec318 to ee04696 Compare April 1, 2025 16:58
@jairad26 jairad26 force-pushed the jai/js-coll-config branch from bf41525 to a418fc1 Compare April 1, 2025 16:58
@jairad26 jairad26 force-pushed the jai/js-client-regen branch from ee04696 to 4960013 Compare April 1, 2025 17:06
@jairad26 jairad26 force-pushed the jai/js-coll-config branch 2 times, most recently from 7ce172a to 525bda3 Compare April 1, 2025 17:12
@jairad26 jairad26 force-pushed the jai/js-client-regen branch 2 times, most recently from 48d0344 to e5513bc Compare April 1, 2025 17:20
@jairad26 jairad26 force-pushed the jai/js-coll-config branch 3 times, most recently from 92fcbe9 to e321409 Compare April 4, 2025 18:44
@jairad26 jairad26 force-pushed the jai/js-client-regen branch from fc4ab73 to db274a6 Compare April 4, 2025 18:44
@jairad26 jairad26 force-pushed the jai/js-coll-config branch from e321409 to 1723e86 Compare April 4, 2025 18:48
@jairad26 jairad26 force-pushed the jai/js-client-regen branch from db274a6 to 08a5418 Compare April 4, 2025 18:48
@jairad26 jairad26 force-pushed the jai/js-coll-config branch from ef0582e to 5f47690 Compare April 16, 2025 17:53
@jairad26 jairad26 force-pushed the 03-25-server-coll-config-response branch from 69ef0ab to 7329be6 Compare April 16, 2025 17:53
@jairad26 jairad26 force-pushed the jai/js-coll-config branch from 5f47690 to d8bbe4e Compare April 16, 2025 17:56
@jairad26 jairad26 force-pushed the 03-25-server-coll-config-response branch 2 times, most recently from 0bcaab3 to c81195e Compare April 16, 2025 20:57
@jairad26 jairad26 force-pushed the jai/js-coll-config branch 2 times, most recently from 4e82ab3 to 51c6447 Compare April 16, 2025 21:00
@jairad26 jairad26 force-pushed the 03-25-server-coll-config-response branch from c81195e to 13b7424 Compare April 16, 2025 21:00
@jairad26 jairad26 force-pushed the jai/js-coll-config branch from 51c6447 to 7ed7749 Compare April 16, 2025 21:02
@jairad26 jairad26 marked this pull request as ready for review April 16, 2025 21:04
@jairad26 jairad26 mentioned this pull request Apr 16, 2025
Merged
1 task
@jairad26 jairad26 force-pushed the jai/js-coll-config branch 5 times, most recently from 2ba2d00 to cabc70d Compare April 17, 2025 21:33
@jairad26 jairad26 force-pushed the 03-25-server-coll-config-response branch from 2b50502 to f464c51 Compare April 17, 2025 21:38
@jairad26 jairad26 force-pushed the jai/js-coll-config branch 2 times, most recently from 69958a4 to 8827040 Compare April 17, 2025 21:42
@jairad26 jairad26 force-pushed the 03-25-server-coll-config-response branch from f464c51 to 4b4277d Compare April 17, 2025 21:42
@jairad26 jairad26 force-pushed the jai/js-coll-config branch 2 times, most recently from 7948fc7 to 2f333dc Compare April 17, 2025 22:07
@jairad26 jairad26 force-pushed the 03-25-server-coll-config-response branch from 4b4277d to f3ec5a5 Compare April 18, 2025 00:32
@jairad26 jairad26 force-pushed the jai/js-coll-config branch from 2f333dc to 87d1b56 Compare April 18, 2025 00:32
@jairad26 jairad26 changed the base branch from 03-25-server-coll-config-response to main April 18, 2025 01:28
@jairad26 jairad26 force-pushed the jai/js-coll-config branch from 87d1b56 to f8328d7 Compare April 18, 2025 01:29
@jairad26
Copy link
Contributor Author

reviewed with Philip offline

@jairad26 jairad26 merged commit 43f0f29 into main Apr 18, 2025
69 checks passed
@jairad26 Graphite App
Copy link
Contributor Author

Merge activity

  • Apr 17, 10:46 PM EDT: A user merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jairad26