-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[ENH] Docs - better image sizing + formats to improve pageload times #4251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
@@ -68,7 +68,7 @@ const CloudSignUp: React.FC = () => { | |||
</div> | |||
<div className="h-full flex items-start justify-end flex-shrink-0 "> | |||
<Image | |||
src="/cloud-art.svg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove the svg file as well to avoid confusion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep it, just in case we want to generate the same art in new sizes. Much easier than chasing down a Figma file. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd think figma would be the repository we should use for graphics sources and not the deployed app. But fine with either way.
@@ -15,7 +15,7 @@ | |||
New to Chroma? Check out the [getting started guide](./getting-started) | |||
{% /Banner %} | |||
|
|||
 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
Switches two large SVGs to a more appropriate format + dimension.
Test plan
How are these changes tested?
Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?