Skip to content

[ENH] Docs - better image sizing + formats to improve pageload times #4251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025
Merged

[ENH] Docs - better image sizing + formats to improve pageload times #4251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/docs.trychroma.com/components/header/cloud-signup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ const CloudSignUp: React.FC = () => {
</div>
<div className="h-full flex items-start justify-end flex-shrink-0 ">
<Image
src="/cloud-art.svg"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the svg file as well to avoid confusion?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep it, just in case we want to generate the same art in new sizes. Much easier than chasing down a Figma file. WDYT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd think figma would be the repository we should use for graphics sources and not the deployed app. But fine with either way.

src="/cloud-art.jpg"
alt="Cloud Art"
width={128}
height={155}
Expand Down
6 changes: 3 additions & 3 deletions docs/docs.trychroma.com/markdoc/content/docs/overview/introduction.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
New to Chroma? Check out the [getting started guide](./getting-started)
{% /Banner %}

![Chroma Computer](/computer.svg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

![Chroma Computer](/computer.png)

Chroma gives you everything you need for retrieval:

Expand Down Expand Up @@ -44,7 +44,7 @@ In JavaScript, use the Chroma JS/TS Client to connect to a Chroma server. Instal

{% Tab label="yarn" %}
```terminal
yarn add chromadb chromadb-default-embed
yarn add chromadb chromadb-default-embed
```
{% /Tab %}

Expand All @@ -56,7 +56,7 @@ npm install --save chromadb chromadb-default-embed

{% Tab label="pnpm" %}
```terminal
pnpm install chromadb chromadb-default-embed
pnpm install chromadb chromadb-default-embed
```
{% /Tab %}

Expand Down
Binary file added docs/docs.trychroma.com/public/cloud-art.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/docs.trychroma.com/public/computer.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading