-
Notifications
You must be signed in to change notification settings - Fork 38
Fix Windows 10 support. #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Travis CI failed for an unrelated reason, PTAL. |
Excited to see this get merged. |
uname_os() {
os=$(uname -s | tr '[:upper:]' '[:lower:]')
case "$os" in
msys_nt*) os="windows" ;;
mingw*) os="windows" ;;
esac
echo "$os"
} You'll probably want something like this to be more friendly with
|
+1 also just ran into this issue for Please add this case and merge! :) |
Closes client9#13.
Thank you! |
@AlekSi and friends... I'd be happy to give you commit rights if you want! Windows is something I'm never going to be able to support! |
@client9 If you need help with Windows support I'm happy to help. I work on Windows full time and fix this kind of stuff constantly :P |
and it was so 💥 thanks @syntaqx |
Same here, my company is now relying on this package so have a vested interest in keeping it working smoothly on all platforms :) Would be happy to help maintain. Thanks again for the fast reply and for merging! 💯 |
In my case we have a cross-platform installer script for a software package, which users can |
My first use case was when I was using https://goreleaser.com/ to automate binary releases for a Go project. They had the project as a dependency. Now I use it for pretty much any scripting suite I deliver. I work in operations/devops/infrastructure so scripts and their compatibility is life. |
Closes #13.