Skip to content

uname_os_check 'MSYS_NT-10.0' got converted to 'msys_nt-10.0' which is not a GOOS value #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AlekSi opened this issue Dec 10, 2018 · 1 comment · Fixed by #14
Closed

uname_os_check 'MSYS_NT-10.0' got converted to 'msys_nt-10.0' which is not a GOOS value #13

AlekSi opened this issue Dec 10, 2018 · 1 comment · Fixed by #14

Comments

@AlekSi
Copy link
Contributor

AlekSi commented Dec 10, 2018

It is the same issue as #3 which is not really fixed. 519ed57 added msys_nt, but not msys_nt-10.0.
AlekSi added a commit to AlekSi/shlib that referenced this issue Dec 10, 2018
@AlekSi
Fix Windows 10 support.
b265967 
Closes client9#13.
This was referenced Dec 10, 2018
Merged
Open
@AlekSi
Copy link
Contributor Author

AlekSi commented Dec 18, 2018

It also fails on AppVeyor: https://ci.appveyor.com/project/AlekSi/reform/builds/21094857/job/esq6cyx4tgwfiisb

$ curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b c:\gopath/bin v1.12.3

golangci/golangci-lint crit uname_os_check 'MSYS_NT-6.3' got converted to 'msys_nt-6.3' which is not a GOOS value. Please file bug at https://github.com/client9/shlib

@AlekSi AlekSi mentioned this issue Dec 18, 2018
Merged
This was referenced Jan 21, 2019
Closed
Merged
Closed
mholt pushed a commit to caddyserver/certmagic that referenced this issue Mar 19, 2019
@dschwar @mholt
use go-acme/lego (#31)
ee1543e 
* use go-acme/lego

* Use master branch of go-lego/acme since v2.3.0 still has a dependency on xenolf/lego

* Use golangci-lint since gometalinter is depricated

* different way of installing golangci-lint for appveyor

* Removing golangci-lint from Appveyor because of client9/shlib#13
@thaJeztah thaJeztah mentioned this issue Mar 30, 2019
Merged
@mholt mholt mentioned this issue Mar 30, 2019
Closed
AlekSi added a commit to AlekSi/shlib that referenced this issue Apr 30, 2019
@AlekSi
Fix Windows 10 support.
a76a4cb 
Closes client9#13.
AlekSi added a commit to AlekSi/shlib that referenced this issue Apr 30, 2019
@AlekSi
Fix Windows 10 support.
56b1c04 
Closes client9#13.
@AlekSi AlekSi mentioned this issue Apr 30, 2019
Merged
@XVilka XVilka mentioned this issue Oct 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Windows 10 support. AlekSi/shlib
1 participant
@AlekSi