Skip to content

fix: 🐛 Codebase indexing is not starting on load #5993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

chezsmithy
Copy link
Contributor

Description

Codebase indexing was not starting on load of the extension.

Checklist

  • I've read the contributing guide
  • The relevant docs, if any, have been updated or created
  • The relevant tests, if any, have been updated or created

Screenshots

[ For visual changes, include screenshots. Screen recordings are particularly helpful, and appreciated! ]

Tests

Tested through visual inspection of loading the extension in the debugger and observing indexing now seems to start as expected.

@chezsmithy chezsmithy requested a review from a team as a code owner June 5, 2025 00:14
@chezsmithy chezsmithy requested review from Patrick-Erichsen and removed request for a team June 5, 2025 00:14
Copy link

cubic-dev-ai bot commented Jun 5, 2025

Your cubic subscription is currently inactive. Please reactivate your subscription to receive AI reviews and use cubic.

Copy link

netlify bot commented Jun 5, 2025

Deploy Preview for continuedev ready!

Name Link
🔨 Latest commit e391d58
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/6840ee1a9b550000080071a1
😎 Deploy Preview https://deploy-preview-5993--continuedev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 5, 2025
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jun 5, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 5, 2025
@Patrick-Erichsen
Copy link
Collaborator

@chezsmithy how does switching the await to void fix this? Worked for me but just curious 😅

@chezsmithy chezsmithy changed the title fix: 🐛 Codebase Indexing was not starting on load fix: 🐛 Codebase indexing is not starting on load Jun 5, 2025
@chezsmithy
Copy link
Contributor Author

Fix to resolve inital loading issues caused by: #5894

@Patrick-Erichsen
Copy link
Collaborator

#5994 - this will fix the prettier issue.

@chezsmithy
Copy link
Contributor Author

@chezsmithy how does switching the await to void fix this? Worked for me but just curious 😅

Well now, only the async gods will know. I fixed it using code inspection to to the previous state, but upon further review, there is a crazy amount of aysnc functions being orchestrated in CodeBaseIndexer.ts. My best guess is by adding the await (added to fix an eslint issue), it's not letting the outer async function to continue which is blocking the indexing start.

@chezsmithy
Copy link
Contributor Author

chezsmithy commented Jun 5, 2025

#5994 - this will fix the prettier issue.

@Patrick-Erichsen ironically caused by my PR :) Thank you. PS, I have prettier enabled fully so this shouldn't happen again.

@Patrick-Erichsen
Copy link
Collaborator

Patrick-Erichsen commented Jun 5, 2025

No worries, took us way to long to get prettier enabled in CI! But yeah that seems plausible, works for me so 🤷‍♂️

Linting fix PR has been merged so just merge main and then I can approve this 👍

@chezsmithy chezsmithy force-pushed the fix-codebase-indexing-not-starting branch from 66a4c90 to e391d58 Compare June 5, 2025 01:08
@Patrick-Erichsen Patrick-Erichsen merged commit 3c5332a into continuedev:main Jun 5, 2025
34 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Jun 5, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants