Skip to content

Generate endpoints for X-Scope-OrgID injection (multi-tenancy) #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jul 31, 2021

Conversation

junkiebev
Copy link
Contributor

@junkiebev junkiebev commented Jul 26, 2021

What this PR does:

Enhancement that builds the nginx config for setting X-Scope-OrgID locations for a specified list of .Values.config.auth_orgs values.

This allows multi-tenancy to easily work for pushed metrics, with auth enabled. I also cleaned up some redundant templating.

Fixes: #72

Checklist

  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@nschad
Copy link
Collaborator

nschad commented Jul 29, 2021

Cool. @junkiebev Please provide a short description CHANGELOG entry

I guess this fixes:
#72

@junkiebev junkiebev force-pushed the master branch 3 times, most recently from 77f0415 to 62d4cdb Compare July 29, 2021 14:48
@junkiebev
Copy link
Contributor Author

junkiebev commented Jul 29, 2021

Cool. @junkiebev Please provide a short description CHANGELOG entry

I guess this fixes:
#72

I updated the changelog and I think I've done everything correctly, but the DCO signoff is failing for some reason... Maybe b/c I used the web interface for editing?

@nschad
Copy link
Collaborator

nschad commented Jul 29, 2021

Cool. @junkiebev Please provide a short description CHANGELOG entry
I guess this fixes:
#72

I updated the changelog and I think I've done everything correctly, but the DCO signoff is failing for some reason...

Almost :P. There is atleast one commit (db3c665) without a DCO.

message from dco: Commit sha: db3c665, Author: Jeff Kolb, Committer: GitHub; The sign-off is missing.

Jeff Kolb and others added 10 commits July 29, 2021 16:29
Signed-off-by: Jeff Kolb <[email protected]>
Signed-off-by: Jeff Kolb <[email protected]>
Signed-off-by: Jeff Kolb <[email protected]>
Signed-off-by: Jeff Kolb <[email protected]>
Signed-off-by: Tom Hayward <[email protected]>
Signed-off-by: Jeff Kolb <[email protected]>
Signed-off-by: Tom Hayward <[email protected]>
Signed-off-by: Jeff Kolb <[email protected]>
@junkiebev
Copy link
Contributor Author

Cool. @junkiebev Please provide a short description CHANGELOG entry
I guess this fixes:
#72

I updated the changelog and I think I've done everything correctly, but the DCO signoff is failing for some reason...

Almost :P. There is atleast one commit (db3c665) without a DCO.

message from dco: Commit sha: db3c665, Author: Jeff Kolb, Committer: GitHub; The sign-off is missing.

All set now!

@nschad nschad merged commit 175d620 into cortexproject:master Jul 31, 2021
@nschad nschad mentioned this pull request Oct 5, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants