add autoscaler for ingesters #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kd7lxl
force-pushed
the
hpa
branch
2 times, most recently
from
a86e62e to
835f81d
Compare
nschad
reviewed
Jul 29, 2021
Signed-off-by: Tom Hayward <[email protected]>
|
Oops, you beat me to the merge/rebase. |
nschad
approved these changes
Jul 29, 2021
junkiebev
pushed a commit
to junkiebev/cortex-helm-chart
that referenced
this pull request
Jul 29, 2021
Signed-off-by: Tom Hayward <[email protected]> Signed-off-by: Jeff Kolb <[email protected]>
nschad
added a commit
that referenced
this pull request
Jul 31, 2021
* adding optional auth-org generation code Signed-off-by: Jeff Kolb <[email protected]> * Added documentation Signed-off-by: Jeff Kolb <[email protected]> * Bumping version number Signed-off-by: Jeff Kolb <[email protected]> * Un-Bumping version number Signed-off-by: Jeff Kolb <[email protected]> * Adding changelog description Signed-off-by: Jeff Kolb <[email protected]> * added alertmanager-config example, added value attributes (#181) Signed-off-by: Raphael Grömmer <[email protected]> Signed-off-by: Jeff Kolb <[email protected]> * Passing DCO test one hopes Signed-off-by: Jeff Kolb <[email protected]> * update docs also in the tmpl file (#186) Signed-off-by: ShuzZzle <[email protected]> Signed-off-by: Jeff Kolb <[email protected]> * add autoscaler for ingesters (#182) Signed-off-by: Tom Hayward <[email protected]> Signed-off-by: Jeff Kolb <[email protected]> * define namespace in templates (#184) Signed-off-by: Tom Hayward <[email protected]> Signed-off-by: Jeff Kolb <[email protected]> * fix: documentation to match helm-docs spec Signed-off-by: ShuzZzle <[email protected]> * fix: auth_orgs under wrong section and use %d for http listen port Signed-off-by: ShuzZzle <[email protected]> Co-authored-by: Raphael Grömmer <[email protected]> Co-authored-by: Niclas Schad <[email protected]> Co-authored-by: Tom Hayward <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds a
HorizontalPodAutoscalerfor the ingesters.https://cortexmetrics.io/docs/guides/capacity-planning/ describes that ingester memory grows as series are added, so this autoscaler tracks memory usage to make scaling decisions.
https://cortexmetrics.io/docs/guides/ingesters-scaling-up-and-down/#scaling-down says that "adding more ingesters to a Cortex cluster is considered a safe operation", so this autoscaler behavior is configured to allow adding one ingester pod at a time, but does not automatically scale down.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]