CNDB-13534: Add RequestFailureReason.FEATURE_NEEDS_INDEX_REBUILD

[driftx]

The main difference was porting FeatureNeedsIndexRebuildException.

[djatnieks]

I looked at the test failures reported above by Butler and they all look like known failing or flaky tests on the 5.0 test failure list

I don't think Butler knows how to do a correct comparison with main-5.0 - meaning I think it always compares PR results to main.

One thing, if you didn't do it already, is to run the "verify" script that I think I mentioned previously - it identified all the unit and distributed tests that were touched by the most recent commit and executes them. For a relatively large commit like this, that's my typical method of verifying the port

[djatnieks]

I checked out the branch and got a compile error:

    [javac] /Users/danj/projects/cc-main-5.0/test/unit/org/apache/cassandra/index/sai/disk/v1/kdtree/KDTreeIndexBuilder.java:194: error: cannot find symbol
    [javac]             assertThat(searcher, is(instanceOf(KDTreeIndexSearcher.class)));
    [javac]                                     ^
    [javac]   symbol:   method instanceOf(Class<KDTreeIndexSearcher>)
    [javac]   location: class KDTreeIndexBuilder

Then I realized the CI build has the same error - weird that it ran tests if the build part had a problem 🤷🏻

[driftx]

Then I realized the CI build has the same error - weird that it ran tests if the build part had a problem 🤷🏻

I think that was because your commits got in and caused a small conflict that I resolved in the web interface. I've rebased and pushed it now.

[djatnieks]

The SAI_CURRENT_VERSION property in CassandraRelevantProperties should be placed in alphabetical order in 5.0.

[djatnieks]

Butler results are easier to read now - there are some failures in these new tests that were added FeaturesVersionSupport*Test - maybe something in 5.0 that is making those fail?
e.g.
http://butler-stargazer.aws.dsinternal.org/#/ci/upstream/workflow/ds-cassandra-pr-gate/job/CNDB-14282/failure/junit.framework.TestSuite?test_name=org.apache.cassandra.distributed.test.sai.features.FeaturesVersionSupportAATest-_jdk11

[driftx]

That wasn't needed in main because there's no BM25 feature to test, and so no backwards compatibility issues to handle.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[cassci-bot]

❌ Build ds-cassandra-pr-gate/PR-1781 rejected by Butler

---

15 new test failure(s) in 5 builds
See build details here

---

Found 15 new test failures

Test	Explanation	Branch history	Upstream history
....r.PendingAntiCompactionTest.testRetriesTimeout	regression	🔴🔴🔴🔵
...adCommitLogAndSSTablesWithDroppedColumnTestCC40	regression	🔴🔴🔴🔴
...adCommitLogAndSSTablesWithDroppedColumnTestCC50	regression	🔴🔴🔴🔴
...oadCommitLogAndSSTablesWithDroppedColumnTestDSE	regression	🔴🔴🔴🔴
...thRestartTest.testReadingValuesOfDroppedColumns	regression	🔴🔴🔴🔴
o.a.c.i.s.c.BM25Test.testCollections	regression	🔴🔴🔴🔴
...est.testOrderingSeveralSSTablesWithMapPredicate	regression	🔴🔴🔴🔴
...uldTolerateDuplicatedRowIDsAfterMemtableUpdates	regression	🔴🔴🔴🔴
...ectorTypeTest.newJVectorOptionsTestVersion2[ca]	regression	🔴🔴🔴🔴
...ectorTypeTest.newJVectorOptionsTestVersion2[dc]	regression	🔴🔴🔴🔴
...ectorTypeTest.newJVectorOptionsTestVersion4[ca]	regression	🔴🔴🔴🔴
...ectorTypeTest.newJVectorOptionsTestVersion4[dc]	regression	🔴🔴🔴🔴
...lushingTest.testFlushingLargeStaleMemtableIndex	regression	🔴🔴🔴🔴
...cySSTableTest.testVerifyOldDroppedTupleSSTables	regression	🔴🔴🔴🔴
o.a.c.t.SSTablePartitionsTest.testDirectory	regression	🔴🔴🔴🔴

---

Found 115 known test failures