CNDB-14308 Port CNDB-13848-followup 3508620089

[djatnieks]

What is the issue

CNDB-14308: Port CNDB-13848-followup 3508620 to main-5.0

What does this PR fix and why was it fixed

This PR is porting the following commit from main branch to main-5.0 branch.

CNDB-13848-followup: add IFilterSerializer interface to avoid type casting during serializaion. (#1711) 3508620 Zhao Yang [email protected] Apr 28, 2025 at 1:57 AM

This 5.0 changes here are much simplified from the main branch version, due to :

• differences in the bloom filter implementation (there is only one location, FilterComponent.save, that saves/flushes the bloom filter compared to several places in main.
• main code changed from direct field access to the bloom filter serializer to using a getter, and 5.0 already uses BloomFilterSerializer.forVersion to access the serializer based on old/new serialization format.
• main branch IFilterSerializer and IFilterDeserializer interfaces are not needed in 5.0

The remaining change ported here is the addition of isSerializable to the 5.0 IFilter interface and implementations.

[github-actions]

Checklist before you submit for review

• Make sure there is a PR in the CNDB project updating the Converged Cassandra version
• Use NoSpamLogger for log lines that may appear frequently in the logs
• Verify test results on Butler
• Test coverage for new/modified code is > 80%
• Proper code formatting
• Proper title for each commit staring with the project-issue number, like CNDB-1234
• Each commit has a meaningful description
• Each commit is not very long and contains related changes
• Renames, moves and reformatting are in distinct commits
• All new files should contain the DataStax copyright header instead of the Apache License one

[djatnieks]

NOTE:

If this PR can get approved, please merge it for me as I will be OOO for a week. TIA.

Ideally, this PR should be merged to immediately follow the changes from CNDB-14282 in PR #1781

Finally, please use the "Rebase and merge" option.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[cassci-bot]

❌ Build ds-cassandra-pr-gate/PR-1788 rejected by Butler

---

17 new test failure(s) in 1 builds
See build details here

---

Found 17 new test failures

Showing only first 15 new test failures

Test	Explanation	Branch history	Upstream history
...estInterruptedExceptionCachedCounterLockManager	regression	🔴
....r.PendingAntiCompactionTest.testRetriesTimeout	regression	🔴
...adCommitLogAndSSTablesWithDroppedColumnTestCC40	regression	🔴
...adCommitLogAndSSTablesWithDroppedColumnTestCC50	regression	🔴
...thRestartTest.testReadingValuesOfDroppedColumns	regression	🔴
o.a.c.i.s.c.BM25Test.testCollections	regression	🔴
...est.testOrderingSeveralSSTablesWithMapPredicate	regression	🔴
...uldTolerateDuplicatedRowIDsAfterMemtableUpdates	regression	🔴
...ectorTypeTest.newJVectorOptionsTestVersion2[ca]	regression	🔴
...ectorTypeTest.newJVectorOptionsTestVersion2[dc]	regression	🔴
...ectorTypeTest.newJVectorOptionsTestVersion4[ca]	regression	🔴
...lushingTest.testFlushingLargeStaleMemtableIndex	regression	🔴
...cySSTableTest.testVerifyOldDroppedTupleSSTables	regression	🔴
o.a.c.t.SSTablePartitionsTest.testDirectory	regression	🔴
o.a.c.u.b.BinLogTest.testTruncationReleasesLogS...	regression	🔴

---

No known test failures found

[driftx]

Approved, but I held off on merging since CNDB-14282 is still open (though I suspect it'd merge fine)