-
Notifications
You must be signed in to change notification settings - Fork 653
feat(collections/unstable): support iterators in sortBy()
#5919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sortBy()
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5919 +/- ##
==========================================
- Coverage 96.25% 96.24% -0.02%
==========================================
Files 491 491
Lines 39460 39451 -9
Branches 5824 5822 -2
==========================================
- Hits 37983 37970 -13
- Misses 1433 1437 +4
Partials 44 44 ☔ View full report in Codecov by Sentry. |
Sorry for the delay. We're deciding how to best handle these changes that should probably be considered unstable. |
I see. No problem 👍 |
sortBy()
sortBy()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice!
Towards: #5470