Skip to content

feat(collections): stabilize Iterable input for chunk, dropLastWhile, dropWhile, intersect, sample, slidingWindows, sortBy, takeLastWhile, takeWhile, and withoutAll #6644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 9, 2025

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented May 8, 2025

This PR adds the support of Iterable inputs for the APIs:

  • chunk
  • dropLastWhile
  • dropWhile
  • intersect
  • sample
  • slidingWindows
  • sortBy
  • takeLastWhile
  • takeWhile
  • withoutAll

These have been first implemented as unstable APIs, and this PR stabilizes them.

related:
#6095
#6090
#6088
#6076
#6036
#6035
#6031
#5925
#5919
#5911

kt3k and others added 2 commits May 8, 2025 15:38
Co-authored-by: Liam Tait <[email protected]>
Co-authored-by: David Luis <[email protected]>
Copy link

codecov bot commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.74%. Comparing base (c338b2f) to head (a63eb00).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6644      +/-   ##
==========================================
- Coverage   94.75%   94.74%   -0.01%     
==========================================
  Files         584      574      -10     
  Lines       46563    46412     -151     
  Branches     6541     6521      -20     
==========================================
- Hits        44120    43974     -146     
+ Misses       2400     2395       -5     
  Partials       43       43              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kt3k kt3k force-pushed the stabilize-collections-iterable-input branch from 98621ea to a63eb00 Compare May 8, 2025 20:41
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit: 🚢

@kt3k kt3k merged commit ce1ee56 into denoland:main May 9, 2025
19 checks passed
@kt3k kt3k deleted the stabilize-collections-iterable-input branch May 9, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants