Add useCdac and liveRuntimeDir build switches for non-windows #5365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up to dotnet#5350 that adds the ability to use the cdac and patch a local copy of the shared framework on non-windows hosts.
|
FWIW I was able to run SOS cdac tests on my local arm64 using dotnet/runtime#113627 |
kasperk81
reviewed
Mar 23, 2025
mikem8361
previously approved these changes
Mar 23, 2025
Co-authored-by: kasperk81 <[email protected]>
max-charlamb
approved these changes
Mar 24, 2025
|
@mikem8361 can you give this another approval? There was a text nit and I rekicked CI. |
mikem8361
approved these changes
Mar 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #5350 that adds the ability to use the cdac and patch a local copy of the shared framework on non-windows hosts.