-
Notifications
You must be signed in to change notification settings - Fork 5.1k
[cDAC] Statically link in native dependencies #113627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d14edcc
to
a80f66b
Compare
9a1760b
to
21667f2
Compare
In the unwinder cmake and in cdacreader.csproj you have proper guarding around not including Line 41 in 21667f2
What I think you'll have to do is follow through with guarding in .cs spots like you did in cmake / csproj. That means #if TARGET_WINDOWS around: Lines 41 to 67 in 21667f2
Line 53 in 21667f2
You may want to throw a PNSE in the latter block. |
… into cdac-static-linking
… into cdac-static-linking
Fixed by adding conditions to the |
/ba-g System.Net timeout #113883 |
/azp run runtime-diagnostics |
Resolves #112416
Creates
cdac
cmake component for native cdac dependencies which is built withtools.cdacreader
Removes Windows only load flag allowing dynamic linking of cdacreader dependencies.
Factors out unwinder base static library and modifies platform specific libraries to be static.
Links in static libraries on supported platforms
Reverts
INSTALL_ALL_ARTIFACTS
implemented in [cDAC] Implement core stackwalking #111759