Update comment on roslyn tasks #12045
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR replaces hard-coded Roslyn targets paths with the new $(RoslynTasksAssembly) property for CopyRefAssembly, Csc, and Vbc tasks.
- Swapped
AssemblyFile="$(RoslynTargetsPath)\Microsoft.Build.Tasks.CodeAnalysis.dll"forAssemblyFile="$(RoslynTasksAssembly)" - Consolidated Roslyn task assembly references behind a single MSBuild property
Comments suppressed due to low confidence (2)
src/Tasks/Microsoft.Common.tasks:107
- [nitpick] Update this comment to mention the
$(RoslynTasksAssembly)property and remove references toRoslynTargetsPathto reflect the new usage.
<!-- NOTE: Keep in sync with SDK: src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets -->
src/Tasks/Microsoft.Common.tasks:108
- [nitpick] Consider adding a
Condition="'$(RoslynTasksAssembly)' != ''"attribute to each<UsingTask>so the build fails more gracefully if the property isn't set.
<UsingTask TaskName="Microsoft.CodeAnalysis.BuildTasks.CopyRefAssembly" AssemblyFile="$(RoslynTasksAssembly)" />
jaredpar
reviewed
Jun 20, 2025
src/Tasks/Microsoft.Common.tasks
Outdated
| <UsingTask TaskName="Microsoft.CodeAnalysis.BuildTasks.Vbc" AssemblyFile="$(RoslynTargetsPath)\Microsoft.Build.Tasks.CodeAnalysis.dll" /> | ||
| <UsingTask TaskName="Microsoft.CodeAnalysis.BuildTasks.CopyRefAssembly" AssemblyFile="$(RoslynTasksAssembly)" /> | ||
| <UsingTask TaskName="Microsoft.CodeAnalysis.BuildTasks.Csc" AssemblyFile="$(RoslynTasksAssembly)" /> | ||
| <UsingTask TaskName="Microsoft.CodeAnalysis.BuildTasks.Vbc" AssemblyFile="$(RoslynTasksAssembly)" /> |
There was a problem hiding this comment.
Had a chat about this on teams, think the right course here is likely update the comments as it doesn't seem to be relevant to modern projects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on dotnet/dotnet#629.
cc @jaredpar