Add roslyn compiler toolset tests #48837
Conversation
|
@jaredpar for a review, thanks |
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.BeforeCommon.targets
Outdated
Show resolved
Hide resolved
jjonescz
changed the title
RoslynCompilerType=Core logic
|
@jaredpar for another look (this is a test+doc only PR now), thanks |
| @@ -137,6 +131,17 @@ Today there is not a 100% reliable way to shutdown the VBCSCompiler process. The | |||
|
|
|||
| To mitigate this we will be fixing the `build-server shutdown` command to be reliable across all the scenarios we care about. The details of this are captured in [issue 45956](https://github.com/dotnet/sdk/issues/45956). | |||
|
|
|||
| ## RoslynCompilerType | |||
|
|
|||
| Based on the value of the `RoslynCompilerType` property, the SDK sets property `RoslynTasksAssembly` to a full path to a [Roslyn build task DLL][roslyn-build-task], | |||
There was a problem hiding this comment.
Lets mention RoslynTargetsPath as well here as getting a compiler properly setup for msbuild seems to require both of these.
There was a problem hiding this comment.
Do you think RoslynTargetsPath will be still required for msbuild even with this: dotnet/msbuild#12045 ? (Assuming that PR works which it currently does not :D)
Anyway, I'm not sure how to define RoslynTargetsPath. Is it also "guaranteed" to be set by the SDK just like RoslynTasksAssembly? But the toolset package doesn't set RoslynTargetsPath, it sets only RoslynTasksAssembly, isn't that wrong?
There was a problem hiding this comment.
I think that it should be guaranteed to be set by SDK projects. That is because it's guaranteed to be set by non-SDK projects, due to msbuid app config, and hence we need to make that it's properly set in all cases. It's been around so long it's seemingly guaranteed that others are depending on it.
This PR is adding compiler toolset package tests (which caught a real bug 🐛, see #48837 (comment)) and updating docs.