Do not count tailcall calli to prevent unnecessary EBP frame #116413
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is common pattern in IL stubs. The SPMI diffs are likely to be small but there's something on linux-x64.
github-actions
bot
added
the
area-CodeGen-coreclr
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
am11
reviewed
Jun 8, 2025
| optIndirectCallCount++; | ||
| // Do not count the tailcall morphed from fgMorphCall -> | ||
| // fgMorphPotentialTailCall -> fgMorphCall as indirect call | ||
| // to prevent forcing EBP frame later. |
There was a problem hiding this comment.
nit: maybe arch neutral terminology would be better here.
Suggested change
| // to prevent forcing EBP frame later. | |
| // to avoid unnecessarily forcing a frame-pointer-based stack frame later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is common pattern in IL stubs. The SPMI diffs are likely to be small but there's something on linux-x64 and linux-arm.
runtime/src/coreclr/jit/regalloc.cpp
Lines 144 to 148 in 0a1fb70