Skip to content

Do not count tailcall calli to prevent unnecessary EBP frame #116413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

Do not count tailcall calli to prevent unnecessary EBP frame #116413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/coreclr/jit/morph.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6373,7 +6373,13 @@ GenTree* Compiler::fgMorphCall(GenTreeCall* call)
if (call->gtCallType == CT_INDIRECT)
{
optCallCount++;
optIndirectCallCount++;
// Do not count the tailcall morphed from fgMorphCall ->
// fgMorphPotentialTailCall -> fgMorphCall as indirect call
// to prevent forcing EBP frame later.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe arch neutral terminology would be better here.

Suggested change
// to prevent forcing EBP frame later.
// to avoid unnecessarily forcing a frame-pointer-based stack frame later.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name is not ideal, it matches Compiler::rpMustCreateEBPFrame though. Let's see what the JIT team tells me, maybe I will need to rewrite it in a different way anyway...

if ((call->gtCallMoreFlags & GTF_CALL_M_TAILCALL) == 0)
{
optIndirectCallCount++;
}
}
else if (call->gtCallType == CT_USER_FUNC)
{
Expand Down
Loading