Fix mail row disappearing and auto closing when clicking a row

[elie222]

Summary by CodeRabbit

Release Notes

• Refactor

  • Updated refetch function across multiple components to use a more flexible parameter structure
  • Modified how thread IDs are passed during email list refresh and archiving operations

• Technical Improvement

  • Enhanced function parameter design to support future extensibility
  • Standardized refetch method signature across email-related components

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
inbox-zero	🔄 Building (Inspect)	Visit Preview	Jan 10, 2025 11:01am

[coderabbitai]

Walkthrough

This pull request introduces a systematic refactoring of the refetch function across multiple files in the web application. The primary change involves modifying the function's parameter structure from an optional array of strings to an optional object containing an optional array of strings. This modification is consistently applied in the Mail page, CommandK component, EmailList component, and the email store, suggesting a deliberate architectural adjustment to enhance function parameter flexibility.

Changes

File	Change Summary
apps/web/app/(app)/mail/page.tsx	Updated refetch parameter from removedThreadIds?: string[] to options?: { removedThreadIds?: string[] }
apps/web/components/CommandK.tsx	Modified refreshEmailList?.refetch call to pass an object with removedThreadIds
apps/web/components/email-list/EmailList.tsx	Updated refetch method signatures for List and EmailList components to use new object parameter structure
apps/web/store/email.ts	Changed type signature of refetchEmailListAtom to accept options object

Sequence Diagram

sequenceDiagram
    participant Caller
    participant RefetchFunction
    participant EmailList

    Caller->>RefetchFunction: Call with options object
    RefetchFunction->>RefetchFunction: Extract removedThreadIds
    RefetchFunction->>EmailList: Perform refetch with filtered threads

Loading

Possibly related PRs

• Show bulk archive progress #237: Directly related changes in CommandK.tsx and EmailList.tsx regarding refetch function parameter structure

Poem

🐰 Refactoring rabbits hop with glee,
Restructuring code so elegantly free,
An object replaces the simple array,
Flexibility blooms in a functional way,
Refetch evolves, clean and bright! 🌟

Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

apps/web/components/email-list/EmailList.tsx (1)

493-493: Consider being explicit with the refetch parameter.

While calling refetch() without parameters is valid, consider being explicit about the intention by passing an empty options object for consistency with other calls.

-markReadThreads([thread.id], () => refetch());
+markReadThreads([thread.id], () => refetch({}));

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d585931 and 86c48e4.

📒 Files selected for processing (4)

• apps/web/app/(app)/mail/page.tsx (1 hunks)
• apps/web/components/CommandK.tsx (1 hunks)
• apps/web/components/email-list/EmailList.tsx (6 hunks)
• apps/web/store/email.ts (1 hunks)

🔇 Additional comments (5)

apps/web/store/email.ts (1)

4-6: LGTM! Type signature change improves extensibility.

The refactoring from removedThreadIds?: string[] to options?: { removedThreadIds?: string[] } enhances type safety and makes it easier to add new parameters in the future without breaking changes.

apps/web/app/(app)/mail/page.tsx (1)

52-61: LGTM! Implementation correctly handles the new parameter structure.

The mutation logic properly handles the new options object while maintaining backward compatibility by checking for the existence of options?.removedThreadIds.

apps/web/components/CommandK.tsx (1)

35-35: LGTM! Correctly adapts to the new parameter structure.

The call to refetch has been properly updated to use the new options object structure.

apps/web/components/email-list/EmailList.tsx (2)

50-50: LGTM! Type signatures properly updated.

The type signatures in both List and EmailList components have been correctly updated to match the new parameter structure.

Also applies to: 178-178

---

281-281: LGTM! Callback implementations correctly use the new structure.

The onArchive, onArchiveBulk, and onTrashBulk callbacks properly implement the new parameter structure for both single and bulk operations.

Also applies to: 364-364, 390-390